diff for duplicates of <4D3FE986.9030603@infradead.org> diff --git a/a/1.txt b/N1/1.txt index 07b9b3f..6f6c8ad 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,7 +5,7 @@ Em 25-01-2011 20:54, Peter Hüwe escreveu: >>> generated by sparse, by replacing the offending 0s with NULL. >> >> I recall (a number of years ago) being told that for things like kmalloc, ->> the proper test was !x, not x = NULL. +>> the proper test was !x, not x == NULL. >> >> julia >> @@ -15,7 +15,7 @@ Em 25-01-2011 20:54, Peter Hüwe escreveu: > > thanks for your input. > So do I understand you correctly if I say -> if(!x) is better than if(x=NULL) in any case? +> if(!x) is better than if(x==NULL) in any case? > > Or only for the kmalloc family? > @@ -28,7 +28,7 @@ Em 25-01-2011 20:54, Peter Hüwe escreveu: > int result = 0; > char *buffer = kmalloc(SIZE); > -> if (buffer = NULL) +> if (buffer == NULL) > return -ENOMEM; > > if (condition1) { @@ -45,7 +45,7 @@ Em 25-01-2011 20:54, Peter Hüwe escreveu: > } > > -> --> So if (buffer = NULL) is in the official CodingStyle - maybe we should +> --> So if (buffer == NULL) is in the official CodingStyle - maybe we should > add a paragraph there as well ;) > > @@ -62,7 +62,3 @@ a pointer. Cheers, Mauro --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 17ef482..149bd3c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,8 +2,8 @@ "ref\0Pine.LNX.4.64.1101252319570.3668@ask.diku.dk\0" "ref\0201101252354.31217.PeterHuewe@gmx.de\0" "From\0Mauro Carvalho Chehab <mchehab@infradead.org>\0" - "Subject\0Re: [PATCH] video/saa7164: Fix sparse warning: Using plain integer\0" - "Date\0Wed, 26 Jan 2011 09:29:42 +0000\0" + "Subject\0Re: [PATCH] video/saa7164: Fix sparse warning: Using plain integer as NULL pointer\0" + "Date\0Wed, 26 Jan 2011 07:29:42 -0200\0" "To\0Peter H\303\274we <PeterHuewe@gmx.de>\0" "Cc\0Julia Lawall <julia@diku.dk>" linux-media@vger.kernel.org @@ -21,7 +21,7 @@ ">>> generated by sparse, by replacing the offending 0s with NULL.\n" ">>\n" ">> I recall (a number of years ago) being told that for things like kmalloc,\n" - ">> the proper test was !x, not x = NULL.\n" + ">> the proper test was !x, not x == NULL.\n" ">>\n" ">> julia\n" ">>\n" @@ -31,7 +31,7 @@ "> \n" "> thanks for your input.\n" "> So do I understand you correctly if I say\n" - "> if(!x) is better than if(x=NULL) in any case?\n" + "> if(!x) is better than if(x==NULL) in any case?\n" "> \n" "> Or only for the kmalloc family?\n" "> \n" @@ -44,7 +44,7 @@ "> int result = 0;\n" "> char *buffer = kmalloc(SIZE);\n" "> \n" - "> if (buffer = NULL)\n" + "> if (buffer == NULL)\n" "> return -ENOMEM;\n" "> \n" "> if (condition1) {\n" @@ -61,7 +61,7 @@ "> }\n" "> \n" "> \n" - "> --> So if (buffer = NULL) is in the official CodingStyle - maybe we should \n" + "> --> So if (buffer == NULL) is in the official CodingStyle - maybe we should \n" "> add a paragraph there as well ;)\n" "> \n" "> \n" @@ -77,10 +77,6 @@ "a pointer.\n" "\n" "Cheers,\n" - "Mauro\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Mauro -61bee9dc70766922d07190c42e124f13c4af0488dcb7b1068d411b1e4c2b03a7 +053220e12e3ad724cf6bfb54f3dcf55ec61625ac1e04068526dbfaf0081c29b9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.