From: Patrick McHardy <kaber@trash.net>
To: Kurt Van Dijck <kurt.van.dijck@eia.be>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] fix validate_link_af in rtnetlink core
Date: Wed, 26 Jan 2011 16:36:44 +0100 [thread overview]
Message-ID: <4D403F8C.2090703@trash.net> (raw)
In-Reply-To: <20110126145523.GA3171@e-circ.dyndns.org>
On 26.01.2011 15:55, Kurt Van Dijck wrote:
> Hi,
>
> I'm not sure about this patch.
>
> I'm testing an API that uses IFLA_AF_SPEC attribute.
> In the rtnetlink core , the set_link_af() member
> of the rtnl_af_ops struct receives the nested attribute
> (as I expected), but the validate_link_af() member
> receives the parent attribute.
> IMO, this patch fixes this.
>
> Since I didn't find any code in iproute2 that makes use
> of this attribute, I wasn't able to verify this on the userspace
> end.
There's code in libnl using this, your patch looks fine to me.
next prev parent reply other threads:[~2011-01-26 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 14:55 [PATCH] fix validate_link_af in rtnetlink core Kurt Van Dijck
2011-01-26 15:36 ` Patrick McHardy [this message]
2011-01-27 22:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D403F8C.2090703@trash.net \
--to=kaber@trash.net \
--cc=kurt.van.dijck@eia.be \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.