Re: [PATCH v2] SPARC: added U-Boot build target: uImage

[Daniel Hellstrom <daniel@gaisler.com>]

Sam Ravnborg wrote:

>Hi Daniel.
>
>Looks better...
>
>  
>
>> define archhelp
>>   echo  '* image        - kernel image ($(boot)/image)'
>>   echo  '* zImage       - stripped kernel image ($(boot)/zImage)'
>>+  echo  '  uImage       - U-Boot SPARC32/LEON Image'
>>   echo  '  tftpboot.img - image prepared for tftp'
>>    
>>
>
>On the commandline you use "sparc32" - so to be consistent I think we should
>use "sparc32" in the help text too. But I do not feel strong about this at all.
>
>
>  
>
>>+OBJCOPYFLAGS_image.bin := -S -O binary -R .note -R .comment
>>+$(obj)/image.bin: $(obj)/image FORCE
>>+	$(call if_changed,objcopy)
>>    
>>
>
>I recall that we remove .note in similar places.
>Could you double check what other archs do here.
>  
>
It seems to me that x86 also removes .note when making bin format.

>  
>
>>+
>>+$(obj)/image.gz: $(obj)/image.bin
>>+	$(call if_changed,gzip)
>>+
>>+# Start of Main memory which this Linux kernel will be loaded to.
>>+ifndef CONFIG_UBOOT_LOAD_ADDR
>>+CONFIG_UBOOT_LOAD_ADDR=0x40004000
>>+endif
>>    
>>
>
>I do not see that value in testign for the three newly introduced
>Kconfig symbols.
>In your backported kernel it may make sense but in mainline the symbols
>will always be defined as Kconfig define them.
>
>So just reference them direct.
>  
>
Good point, see new patch.

Thanks,
Daniel