From: Hannes Reinecke <hare@suse.de>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: James Bottomley <James.Bottomley@suse.de>,
dgilbert@interlog.com,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [LSF/MM TOPIC] SCSI referrals support
Date: Wed, 26 Jan 2011 16:54:24 +0100 [thread overview]
Message-ID: <4D4043B0.5070209@suse.de> (raw)
In-Reply-To: <4D3D43BB.1060805@panasas.com>
On 01/24/2011 10:17 AM, Boaz Harrosh wrote:
> On 01/24/2011 10:04 AM, Hannes Reinecke wrote:
[ .. ]
>> Ah, if it were so easy. Currently sense codes have two problems:
>>
>> - They are limited to 96 bytes. Anything larger than that will just
>> be discarded (or crash with your patch above :-)
>
> It will not crash.
>
Oh, indeed. You are right.
> I have a patchset here that expands the request/scsi_cmnd sense_buffer
> support to the maximum 260 bytes supported by the std.
>
> If you want I can revive it. It is a sweep of all drivers, but a small
> one, nothing like the accessors changes.
>
Please. Can you send it to me?
I have a prototype working right now, and expanding the sense buffer
would be a good idea here.
>> - They inherit the same lifetime than the scsi command. But for any
>> decent handling you really need to push them into some
>> asynchronous context as you might well be within an interrupt
>> handler here.
>
> No that's fine. request->sense is a user supplied buffer that extends
> the life of scsi_cmnd. above code just copies from a scsi-layer dma-able
> buffer to the request->sense buffer. interrupt-time is fine.
>
>> I'm currently working on a handling framework using relayfs
>> (basically blktrace for SCSI Unit Attention); I can be doing a short
>> presentation at LSF if requested.
>>
>
> That would be interesting. Thanks
>
Ok, will then be doing it.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-26 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 16:00 [LSF/MM TOPIC] SCSI referrals support Hannes Reinecke
2011-01-20 16:14 ` Douglas Gilbert
2011-01-20 16:36 ` James Bottomley
2011-01-23 11:25 ` Boaz Harrosh
2011-01-24 8:04 ` Hannes Reinecke
2011-01-24 9:17 ` Boaz Harrosh
2011-01-26 15:54 ` Hannes Reinecke [this message]
2011-03-31 16:40 ` Bart Van Assche
2011-03-31 17:56 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4043B0.5070209@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@suse.de \
--cc=bharrosh@panasas.com \
--cc=dgilbert@interlog.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.