From: Darren Hart <dvhart@linux.intel.com>
To: Adrian Alonso <aalonso@secretlab.ca>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 05/25][v3] u-boot: disable -Os option not supported by gcc
Date: Wed, 26 Jan 2011 10:00:50 -0800 [thread overview]
Message-ID: <4D406152.3010009@linux.intel.com> (raw)
In-Reply-To: <1296063743-4676-1-git-send-email-aalonso@secretlab.ca>
On 01/26/2011 09:42 AM, Adrian Alonso wrote:
> * Disable -Os optspace option not supported by gcc use insted -O2
> * v2 Remove Make file patch
> * v3 use EXTRA_OEMAKE variable, override default OPTFLAGS settings
> in u-boot.inc, Powerpc targets build only with -O1, -O2 optflags
> Build failures are related to gcc bugs #44392 and #45052
> * Bump PR
>
> Signed-off-by: Adrian Alonso<aalonso@secretlab.ca>
Looks good for the -Os problem.
Reviewed-by: Darren Hart<dvhart@linux.intel.com>
I noticed that the SRCREV is defined in this file.
Typically this should be in
meta/conf/distro/include/poky-default-revisions.inc
--
Darren
> ---
> recipes-bsp/uboot/u-boot-xilinx_git.bb | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-bsp/uboot/u-boot-xilinx_git.bb b/recipes-bsp/uboot/u-boot-xilinx_git.bb
> index 50d99e3..a373428 100644
> --- a/recipes-bsp/uboot/u-boot-xilinx_git.bb
> +++ b/recipes-bsp/uboot/u-boot-xilinx_git.bb
> @@ -1,9 +1,11 @@
> require ../meta/recipes-bsp/uboot/u-boot.inc
> -PR = "r2"
> +PR = "r3"
>
> +EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} OPTFLAGS='-O2'"
> BRANCH="master"
> TAG="e094f2479ea339d7f48b6826f06f0be4984d9a98"
> -SRC_URI = "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git"
> +SRC_URI = "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git \
> + "
> SRCREV = "${TAG}"
>
> inherit xilinx-boot
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
next prev parent reply other threads:[~2011-01-26 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 17:42 [PATCH 05/25][v3] u-boot: disable -Os option not supported by gcc Adrian Alonso
2011-01-26 18:00 ` Darren Hart [this message]
2011-01-26 18:28 ` Saul Wold
2011-01-26 18:55 ` Adrian Alonso
2011-01-26 19:32 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D406152.3010009@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=aalonso@secretlab.ca \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.