From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [sim-auth PATCH 4/5] Add doc/gba-authentication.txt
Date: Wed, 26 Jan 2011 16:43:21 -0600 [thread overview]
Message-ID: <4D40A389.1060506@gmail.com> (raw)
In-Reply-To: <1295542402-26857-5-git-send-email-Pekka.Pessi@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]
Hi Pekka,
On 01/20/2011 10:53 AM, Pekka.Pessi(a)nokia.com wrote:
> From: Pekka Pessi <Pekka.Pessi@nokia.com>
>
> ---
> doc/gba-authentication.txt | 70 ++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 70 insertions(+), 0 deletions(-)
> create mode 100644 doc/gba-authentication.txt
>
Can you do me a favor and reflow this document a bit? Right now you're
using two tab indentation unnecessarily.
It is also fine to squash patch 4 & 5 together.
Regards,
-Denis
prev parent reply other threads:[~2011-01-26 22:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 16:53 [sim-auth PATCH 0/5] SIM Authentication D-Bus API Pekka.Pessi
2011-01-20 16:53 ` [sim-auth PATCH 1/5] Add doc/sim-authentication-api.txt Pekka.Pessi
2011-01-20 16:53 ` [sim-auth PATCH 2/5] Add doc/sim-authentication-api.txt to dist Pekka.Pessi
2011-01-20 16:53 ` [sim-auth PATCH 3/5] Add GBA_U to SIM authentication API Pekka.Pessi
2011-01-20 16:53 ` [sim-auth PATCH 4/5] Add doc/gba-authentication.txt Pekka.Pessi
2011-01-20 16:53 ` [sim-auth PATCH 5/5] Add doc/gba-authentication.txt to dist Pekka.Pessi
2011-01-26 22:43 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D40A389.1060506@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.