From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Hellstrom Date: Thu, 27 Jan 2011 11:06:27 +0000 Subject: Re: [PATCH] SPARC/LEON: FPU-FSR only available when FPU present Message-Id: <4D4151B3.9030807@gaisler.com> List-Id: References: <1296059825-22822-1-git-send-email-daniel@gaisler.com> In-Reply-To: <1296059825-22822-1-git-send-email-daniel@gaisler.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: sparclinux@vger.kernel.org Sam Ravnborg wrote: >On Wed, Jan 26, 2011 at 05:37:05PM +0100, Daniel Hellstrom wrote: > > >>Signed-off-by: Daniel Hellstrom >>--- >> arch/sparc/kernel/cpu.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >>diff --git a/arch/sparc/kernel/cpu.c b/arch/sparc/kernel/cpu.c >>index 0dc714f..7925c54 100644 >>--- a/arch/sparc/kernel/cpu.c >>+++ b/arch/sparc/kernel/cpu.c >>@@ -324,7 +324,7 @@ void __cpuinit cpu_probe(void) >> psr = get_psr(); >> put_psr(psr | PSR_EF); >> #ifdef CONFIG_SPARC_LEON >>- fpu_vers = 7; >>+ fpu_vers = get_psr() & PSR_EF ? ((get_fsr() >> 17) & 0x7) : 7; >> #else >> fpu_vers = ((get_fsr() >> 17) & 0x7); >> #endif >> >> > >This file is full of numbers. >But for new stuff it would be great with symbolic constants. > > Please ack this patch, and see the follow up patch doing some cleaning of PSR/FSR code. >I also do wonder if your new version could be >used for non-leon? >PSR_EF say if the FPU is enabled or not. >If it is disabled can we then trust the FSR.ver field? > > see discussion in other email. Daniel