From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trilok Soni Subject: Re: [PATCH 1/2] input: Modify the qt602240 driver to be compatible with mXT1386 device - renames Date: Thu, 27 Jan 2011 17:02:20 +0530 Message-ID: <4D4157C4.1070702@codeaurora.org> References: <4D3DAE3C.6060806@atmel.com> <20110124170756.GB31066@core.coreip.homeip.net> <4D3EA706.4020308@atmel.com> <4D3EAD67.7030707@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:7047 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754003Ab1A0Lcd (ORCPT ); Thu, 27 Jan 2011 06:32:33 -0500 In-Reply-To: <4D3EAD67.7030707@codeaurora.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Iiro Valkonen Cc: Dmitry Torokhov , linux-input@vger.kernel.org, jy0922.shim@samsung.com Hi Iiro, On 1/25/2011 4:30 PM, Trilok Soni wrote: > Hi Iiro, > > On 1/25/2011 4:03 PM, Iiro Valkonen wrote: >> On 01/24/2011 07:07 PM, Dmitry Torokhov wrote: >>> >>> Thank you for the patch. Could I ask you to split the qt602240->mxt >>> renames from the functional changes so latter are easier to review? >>> >> >> Hi Dmitry, >> >> here's the rename patch. > > Can you submit it as proper patch please, instead of copying it on the reply, > it is hard for me to review. Same goes for the 2nd patch you have submitted > just now. Ping. As mentioned above, it would be nice if you can re-submit your changes as patches, and not just copying them under the signature. Thanks. ---Trilok Soni -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.