All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ulf Samuelsson <ulf.samuelsson@atmel.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: Patching from a file containing a compressed directory	(<directory>.tar.bz2)
Date: Fri, 28 Jan 2011 00:17:54 +0100	[thread overview]
Message-ID: <4D41FD22.2050803@atmel.com> (raw)
In-Reply-To: <ihqdm4$jaj$1@dough.gmane.org>

2011-01-27 01:19, Koen Kooi skrev:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 26-01-11 22:32, Ulf Samuelsson wrote:
>>      Trying to change the at91 linux recipes.
>>      The "experimental" patches to be added on top of the "maxim" patch
>>      can be downloaded from ftp://ftp.at91.com/ and that file
>>      is generated from a directory of patches, which should be applied
>>      in alphabetical order.
>>
>>      When the "obvious" SRC_URI  is used:
>>
>>      ftp://ftp.at91.com/<directory>.tar.bz2;apply=yes \
>>
>>       the files do not get applied in alphabetical order.
>>
>>      It looks to me like they get applied in reverse order,  but I did
>> not check carefully.
>>      I tried adding a "series" file, and recompress, but that failed as
>> well.
>>
>>      Any clue on how to get the patches applied in alphabetical order?
>>
>>      If the patches are in a subdirectory to the recipe, and applied
>> manually
>>      everything is OK, but that seems to be a shame to have to resort to
>> that.
> We don't want such behaviour, putting the patches in OE and adding them
> to SRC_URI is the only acceptable way to do this.

Well no, there is always an option to take the file,
"cat" all the files together to a single file,
which will result in the patches beeing applied in the correct order.

Less ugly than adding 94 patches and listing them in the recipe...

By "Manual", I mean:

do_apply_at91_exp_patch () {
     cd    ${S}
     for    f in `ls ../${PV}-at91-exp.4/*.patch` ; do
         cat $f    | patch -p1
     done
}

Why would that be a problem?

To me, maintaining this is much less work than maintaining a
SRC_URI statement.

Obviously, it would be better if the build system
had a defined order when applying patches from a file
containing multiple patches.


> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFNQLoEMkyGM64RGpERAo3fAJoDwcnY3HrWprnEOFzwcp1+VU/biQCfd0oZ
> dJ7RQ/b2cMdBSdP3NFQsx6M=
> =ZC5T
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel


-- 
Best Regards
Ulf Samuelsson




  reply	other threads:[~2011-01-27 23:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26 21:32 Patching from a file containing a compressed directory (<directory>.tar.bz2) Ulf Samuelsson
2011-01-26 22:57 ` Ulf Samuelsson
2011-01-27  0:19 ` Koen Kooi
2011-01-27 23:17   ` Ulf Samuelsson [this message]
2011-01-28  1:07     ` Chris Larson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D41FD22.2050803@atmel.com \
    --to=ulf.samuelsson@atmel.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.