Re: [PATCH v2] VMX25: Add machine support for vmx25

["Eric Bénard" <eric@eukrea.com>]

Hi Khem,

On 28/01/2011 18:50, Khem Raj wrote:
>> +PREFERRED_PROVIDER_virtual/bootloader = "barebox"
>> +PREFERRED_PROVIDER_virtual/kernel = "linux"
>> +PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg"
>
> what xserver is chosen is s distro choice do not lock it here.
>
not sure of this point : the distro don't know if you want xserver-xorg or 
xserver-kdrive for your machine.
>> +
>> +PREFERRED_VERSION_linux = "2.6.35"
>
> kernel should not be pinned in conf file but in the kernel recipe itself
> you should add PREFERRRED_PROVIDER_yourmacine = ...
>
>> +
>> +MACHINE_FEATURES = "kernel26 alsa ext2 usbhost usbgadget touchscreen keyboard"
>> +
>> +GUI_MACHINE_CLASS = "bigscreen"
>> +XSERVER ?= "xserver-xorg \
>> +           xf86-input-tslib \
>> +           xf86-input-evdev \
>> +           xf86-input-mouse \
>> +           xf86-input-keyboard \
>> +           xf86-video-fbdev \
>> +"
>
> this two defines should be part of distros to pin not machines.
>
I'm not sure of this :
GUI_MACHINE_CLASS is about the machine not the distro.
XSERVER's choice depends on the machine not on the distro.

Eric