[PATCH v2] VMX25: Add machine support for vmx25

[PATCH v2] VMX25: Add machine support for vmx25

[sujak.marek]

* Add config file for http://voipac.com/#X25-DKT-265

Signed-off-by: sujak.marek <sujak.marek@gmail.com>
---
 conf/machine/vmx25.conf |   38 ++++++++++++++++++++++++++++++++++++++
 1 files changed, 38 insertions(+), 0 deletions(-)
 create mode 100644 conf/machine/vmx25.conf

diff --git a/conf/machine/vmx25.conf b/conf/machine/vmx25.conf
new file mode 100644
index 0000000..8ba7197
--- /dev/null
+++ b/conf/machine/vmx25.conf
@@ -0,0 +1,38 @@
+#@TYPE: Machine
+#@Name: Voipac vmx25 module
+#@DESCRIPTION: Machine configuration for Voipac vmx25 module & baseboard
+#@Homepage: http://voipac.com/#X25-DKT-265
+
+TARGET_ARCH = "arm"
+
+PREFERRED_PROVIDER_virtual/bootloader = "barebox"
+PREFERRED_PROVIDER_virtual/kernel = "linux"
+PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg"
+
+PREFERRED_VERSION_linux = "2.6.35"
+
+MACHINE_FEATURES = "kernel26 alsa ext2 usbhost usbgadget touchscreen keyboard"
+
+GUI_MACHINE_CLASS = "bigscreen"
+XSERVER ?= "xserver-xorg \
+           xf86-input-tslib \
+           xf86-input-evdev \
+           xf86-input-mouse \
+           xf86-input-keyboard \
+           xf86-video-fbdev \
+"
+# Data Image FG0700K6DSSWBG01 TFT lcd
+#MACHINE_DISPLAY_WIDTH_PIXELS = "800"
+#MACHINE_DISPLAY_HEIGHT_PIXELS = "480"
+#MACHINE_DISPLAY_PPI = "133"
+
+# ubi fs args
+MKUBIFS_ARGS = "-m 2KiB -e 126KiB -c 989"
+UBINIZE_ARGS = "-m 2KiB -p 128KiB -s 512"
+
+IMAGE_FSTYPES += "tar.gz ubi"
+
+require conf/machine/include/tune-arm926ejs.inc
+
+# used by sysvinit_2
+SERIAL_CONSOLE = "115200 ttymxc0"
-- 
1.7.0.4

Re: [PATCH v2] VMX25: Add machine support for vmx25

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

Dear Marek,


Am Freitag, den 28.01.2011, 14:00 +0100 schrieb sujak.marek:
> * Add config file for http://voipac.com/#X25-DKT-265

could you please add a short note in the commit message if all board
features are working as expected with this configuration or if there are
any “bugs” left.

What distribution is your board build and run tested?

> Signed-off-by: sujak.marek <sujak.marek@gmail.com>

Please configure Git properly with `git config user.name "Marek Sujak"`.

[…]


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v2] VMX25: Add machine support for vmx25

[Marek Sujak]

Dear Paul,

I'm sorry that i don't typed that.
I checked:
console-image -> OK
base-image -> OK
x11-image -> OK
qt4e-image -> +/-OK (Alignment trap)
qt4e-demo-image -> +/-OK (Alignment trap)

It depends on:
barebox 2010.10 + patch.
kernel 2.6.35 + patch.

I will commit these files today.

There are of-course bugs in kernel, but the images works fine for me.
I corrected my Git username as you recommended. (thanks)

Best regard
Marek

On Fri, Jan 28, 2011 at 2:15 PM, Paul Menzel <
paulepanter@users.sourceforge.net> wrote:

> Dear Marek,
>
>
> Am Freitag, den 28.01.2011, 14:00 +0100 schrieb sujak.marek:
> > * Add config file for http://voipac.com/#X25-DKT-265
>
> could you please add a short note in the commit message if all board
> features are working as expected with this configuration or if there are
> any “bugs” left.
>
> What distribution is your board build and run tested?
>
> > Signed-off-by: sujak.marek <sujak.marek@gmail.com>
>
> Please configure Git properly with `git config user.name "Marek Sujak"`.
>
> […]
>
>
> Thanks,
>
> Paul
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>

Re: [PATCH v2] VMX25: Add machine support for vmx25

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

Dear Marek,


A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top
http://en.opensuse.org/openSUSE:Mailing_list_netiquette#Interleaved_style


Am Freitag, den 28.01.2011, 14:44 +0100 schrieb Marek Sujak:

> I'm sorry that i don't typed that.

no problem. It is no hard requirement and unfortunately often left out
in the commit message.

> I checked:
> console-image -> OK
> base-image -> OK
> x11-image -> OK
> qt4e-image -> +/-OK (Alignment trap)
> qt4e-demo-image -> +/-OK (Alignment trap)

What distribution (and Git branch) did you use? The tool chain depends
on this choice.

> It depends on:
> barebox 2010.10 + patch.
> kernel 2.6.35 + patch.
> 
> I will commit these files today.
> 
> There are of-course bugs in kernel, but the images works fine for me.
> I corrected my Git username as you recommended. (thanks)

Thank you for your answer. I do not have any commit access, so I hope
that the other developers will push your patches soon.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v2] VMX25: Add machine support for vmx25

[Marek Sujak]

Dear Paul

A: No.
> Q: Should I include quotations after my reply?
>
> http://daringfireball.net/2007/07/on_top
> http://en.opensuse.org/openSUSE:Mailing_list_netiquette#Interleaved_style
>

I hope this is fixed now.

What distribution (and Git branch) did you use? The tool chain depends
> on this choice.
>


Distribution is angstrom-2010.x. Toolchain is eglibc based, all properties
are "default" without any modifications.
Git branch is "org.openembedded.org". The default one after git clone.
This is the first time that i am trying to push something somewhere so i
hope i do not make any mess.


> > It depends on:
> > barebox 2010.10 + patch.
> > kernel 2.6.35 + patch.
> >
> > I will commit these files today.
> >
> > There are of-course bugs in kernel, but the images works fine for me.
> > I corrected my Git username as you recommended. (thanks)
>
> Thank you for your answer. I do not have any commit access, so I hope
> that the other developers will push your patches soon.
>
>
I hope too. Thank you for your time.

Best regards,
Marek

Re: [PATCH v2] VMX25: Add machine support for vmx25

[Khem Raj]

On Fri, Jan 28, 2011 at 5:00 AM, sujak.marek <sujak.marek@gmail.com> wrote:
> * Add config file for http://voipac.com/#X25-DKT-265
>
> Signed-off-by: sujak.marek <sujak.marek@gmail.com>
> ---
>  conf/machine/vmx25.conf |   38 ++++++++++++++++++++++++++++++++++++++
>  1 files changed, 38 insertions(+), 0 deletions(-)
>  create mode 100644 conf/machine/vmx25.conf
>
> diff --git a/conf/machine/vmx25.conf b/conf/machine/vmx25.conf
> new file mode 100644
> index 0000000..8ba7197
> --- /dev/null
> +++ b/conf/machine/vmx25.conf
> @@ -0,0 +1,38 @@
> +#@TYPE: Machine
> +#@Name: Voipac vmx25 module
> +#@DESCRIPTION: Machine configuration for Voipac vmx25 module & baseboard
> +#@Homepage: http://voipac.com/#X25-DKT-265
> +
> +TARGET_ARCH = "arm"
> +
> +PREFERRED_PROVIDER_virtual/bootloader = "barebox"
> +PREFERRED_PROVIDER_virtual/kernel = "linux"
> +PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg"

what xserver is chosen is s distro choice do not lock it here.

> +
> +PREFERRED_VERSION_linux = "2.6.35"

kernel should not be pinned in conf file but in the kernel recipe itself
you should add PREFERRRED_PROVIDER_yourmacine = ...

> +
> +MACHINE_FEATURES = "kernel26 alsa ext2 usbhost usbgadget touchscreen keyboard"
> +
> +GUI_MACHINE_CLASS = "bigscreen"
> +XSERVER ?= "xserver-xorg \
> +           xf86-input-tslib \
> +           xf86-input-evdev \
> +           xf86-input-mouse \
> +           xf86-input-keyboard \
> +           xf86-video-fbdev \
> +"

this two defines should be part of distros to pin not machines.

> +# Data Image FG0700K6DSSWBG01 TFT lcd
> +#MACHINE_DISPLAY_WIDTH_PIXELS = "800"
> +#MACHINE_DISPLAY_HEIGHT_PIXELS = "480"
> +#MACHINE_DISPLAY_PPI = "133"
> +
> +# ubi fs args
> +MKUBIFS_ARGS = "-m 2KiB -e 126KiB -c 989"
> +UBINIZE_ARGS = "-m 2KiB -p 128KiB -s 512"
> +
> +IMAGE_FSTYPES += "tar.gz ubi"
> +
> +require conf/machine/include/tune-arm926ejs.inc
> +
> +# used by sysvinit_2
> +SERIAL_CONSOLE = "115200 ttymxc0"
> --
> 1.7.0.4
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH v2] VMX25: Add machine support for vmx25

[Eric Bénard]

Hi Khem,

On 28/01/2011 18:50, Khem Raj wrote:
>> +PREFERRED_PROVIDER_virtual/bootloader = "barebox"
>> +PREFERRED_PROVIDER_virtual/kernel = "linux"
>> +PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg"
>
> what xserver is chosen is s distro choice do not lock it here.
>
not sure of this point : the distro don't know if you want xserver-xorg or 
xserver-kdrive for your machine.
>> +
>> +PREFERRED_VERSION_linux = "2.6.35"
>
> kernel should not be pinned in conf file but in the kernel recipe itself
> you should add PREFERRRED_PROVIDER_yourmacine = ...
>
>> +
>> +MACHINE_FEATURES = "kernel26 alsa ext2 usbhost usbgadget touchscreen keyboard"
>> +
>> +GUI_MACHINE_CLASS = "bigscreen"
>> +XSERVER ?= "xserver-xorg \
>> +           xf86-input-tslib \
>> +           xf86-input-evdev \
>> +           xf86-input-mouse \
>> +           xf86-input-keyboard \
>> +           xf86-video-fbdev \
>> +"
>
> this two defines should be part of distros to pin not machines.
>
I'm not sure of this :
GUI_MACHINE_CLASS is about the machine not the distro.
XSERVER's choice depends on the machine not on the distro.

Eric

Re: [PATCH v2] VMX25: Add machine support for vmx25

[Tom Rini]

On 01/28/2011 11:43 AM, Eric Bénard wrote:
> Hi Khem,
>
> On 28/01/2011 18:50, Khem Raj wrote:
>>> +PREFERRED_PROVIDER_virtual/bootloader = "barebox"
>>> +PREFERRED_PROVIDER_virtual/kernel = "linux"
>>> +PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg"
>>
>> what xserver is chosen is s distro choice do not lock it here.
>>
> not sure of this point : the distro don't know if you want xserver-xorg
> or xserver-kdrive for your machine.
>>> +
>>> +PREFERRED_VERSION_linux = "2.6.35"
>>
>> kernel should not be pinned in conf file but in the kernel recipe itself
>> you should add PREFERRRED_PROVIDER_yourmacine = ...
>>
>>> +
>>> +MACHINE_FEATURES = "kernel26 alsa ext2 usbhost usbgadget touchscreen
>>> keyboard"
>>> +
>>> +GUI_MACHINE_CLASS = "bigscreen"
>>> +XSERVER ?= "xserver-xorg \
>>> + xf86-input-tslib \
>>> + xf86-input-evdev \
>>> + xf86-input-mouse \
>>> + xf86-input-keyboard \
>>> + xf86-video-fbdev \
>>> +"
>>
>> this two defines should be part of distros to pin not machines.
>>
> I'm not sure of this :
> GUI_MACHINE_CLASS is about the machine not the distro.
> XSERVER's choice depends on the machine not on the distro.

Agreed.  The machine dictates what will and will not make the hardware 
function here.  That said, we ought to make that the default rather than 
xserver-kdrive :)

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH v2] VMX25: Add machine support for vmx25

[Khem Raj]

On Fri, Jan 28, 2011 at 10:43 AM, Eric Bénard <eric@eukrea.com> wrote:
> Hi Khem,
>
> On 28/01/2011 18:50, Khem Raj wrote:
>>>
>>> +PREFERRED_PROVIDER_virtual/bootloader = "barebox"
>>> +PREFERRED_PROVIDER_virtual/kernel = "linux"
>>> +PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg"
>>
>> what xserver is chosen is s distro choice do not lock it here.
>>
> not sure of this point : the distro don't know if you want xserver-xorg or
> xserver-kdrive for your machine.
>>>

what machine features will make one work and other not. IOW
what machine dependency does it have

>>> +
>>> +PREFERRED_VERSION_linux = "2.6.35"
>>
>> kernel should not be pinned in conf file but in the kernel recipe itself
>> you should add PREFERRRED_PROVIDER_yourmacine = ...
>>
>>> +
>>> +MACHINE_FEATURES = "kernel26 alsa ext2 usbhost usbgadget touchscreen
>>> keyboard"
>>> +
>>> +GUI_MACHINE_CLASS = "bigscreen"
>>> +XSERVER ?= "xserver-xorg \
>>> +           xf86-input-tslib \
>>> +           xf86-input-evdev \
>>> +           xf86-input-mouse \
>>> +           xf86-input-keyboard \
>>> +           xf86-video-fbdev \
>>> +"
>>
>> this two defines should be part of distros to pin not machines.
>>


> I'm not sure of this :
> GUI_MACHINE_CLASS is about the machine not the distro.
> XSERVER's choice depends on the machine not on the distro.

ok I see

>
> Eric
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH v2] VMX25: Add machine support for vmx25

[Marek Sujak]

On Fri, Jan 28, 2011 at 6:50 PM, Khem Raj <raj.khem@gmail.com> wrote:

>
> what xserver is chosen is s distro choice do not lock it here.


I do not agree. What if the machine is tested to work with particular
xserver and with other one have  some issues? Then this could be the right
place.

> +
> > +PREFERRED_VERSION_linux = "2.6.35"
>
> kernel should not be pinned in conf file but in the kernel recipe itself
> you should add PREFERRRED_PROVIDER_yourmacine = ...
>

I will remove this.


> > +
> > +MACHINE_FEATURES = "kernel26 alsa ext2 usbhost usbgadget touchscreen
> keyboard"
> > +
> > +GUI_MACHINE_CLASS = "bigscreen"
> > +XSERVER ?= "xserver-xorg \
> > +           xf86-input-tslib \
> > +           xf86-input-evdev \
> > +           xf86-input-mouse \
> > +           xf86-input-keyboard \
> > +           xf86-video-fbdev \
> > +"
>
> this two defines should be part of distros to pin not machines.
>

Machine should know what features if have. Because for distros it is
impossible to know what are the hw capabilities of particular machine i
think.


Thanks

Best regards,
marek
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Re: [PATCH v2] VMX25: Add machine support for vmx25

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 28-01-11 18:50, Khem Raj wrote:

>> +GUI_MACHINE_CLASS = "bigscreen"
>> +XSERVER ?= "xserver-xorg \
>> +           xf86-input-tslib \
>> +           xf86-input-evdev \
>> +           xf86-input-mouse \
>> +           xf86-input-keyboard \
>> +           xf86-video-fbdev \
>> +"
> 
> this two defines should be part of distros to pin not machines.

Actually not, setting it in machine.conf and then weakly in the
task/images that use it is how it was designed to work.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNQ+HWMkyGM64RGpERAuWlAJ4kx/vowFlJNSw+HMyP/gZJYit2lACeP77f
4C9NGk+AXp81zBtRy8FRZ9A=
=ZNaC
-----END PGP SIGNATURE-----

Re: [PATCH v2] VMX25: Add machine support for vmx25

[Marek Sujak]

Thanks to all

I tried to correct problematic line (PREFERRED_VERSION_linux = ...).
If i understand it wrong please let me know.
I have created and commit-ed new patch.

Best regards
Marek