From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx1.pokylinux.org (Postfix) with ESMTP id 2E8744C80594 for ; Fri, 28 Jan 2011 15:48:20 -0600 (CST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 28 Jan 2011 13:48:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.60,394,1291622400"; d="scan'208";a="597482709" Received: from miles.jf.intel.com (HELO [10.7.199.79]) ([10.7.199.79]) by orsmga002.jf.intel.com with ESMTP; 28 Jan 2011 13:48:19 -0800 Message-ID: <4D4339A3.30007@intel.com> Date: Fri, 28 Jan 2011 13:48:19 -0800 From: Scott Garman User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: poky@yoctoproject.org References: <1296228424.2704.20.camel@scimitar> In-Reply-To: <1296228424.2704.20.camel@scimitar> Subject: Re: [PATCH 3/9] docbook-dsssl-stylesheets: new recipe v1.79 X-BeenThere: poky@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Poky build system developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2011 21:48:20 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 01/28/2011 07:27 AM, Joshua Lock wrote: > On Thu, 2011-01-27 at 14:42 -0800, Scott Garman wrote: >> From: Scott Garman >> >> Recipe migrated from OpenEmbedded. >> >> Signed-off-by: Scott Garman >> --- >> .../docbook-dsssl-stylesheets-native_1.79.bb | 53 ++++++++++++++++++++ >> 1 files changed, 53 insertions(+), 0 deletions(-) >> create mode 100644 meta/recipes-devtools/docbook-dsssl-stylesheets/docbook-dsssl-stylesheets-native_1.79.bb >> >> diff --git a/meta/recipes-devtools/docbook-dsssl-stylesheets/docbook-dsssl-stylesheets-native_1.79.bb b/meta/recipes-devtools/docbook-dsssl-stylesheets/docbook-dsssl-stylesheets-native_1.79.bb >> new file mode 100644 >> index 0000000..24c5364 >> --- /dev/null >> +++ b/meta/recipes-devtools/docbook-dsssl-stylesheets/docbook-dsssl-stylesheets-native_1.79.bb >> @@ -0,0 +1,53 @@ >> +SUMMARY = "DSSSL stylesheets used to transform SGML and XML DocBook files" >> +DESCRIPTION = "DSSSL stylesheets used to transform SGML and XML DocBook files" >> +HOMEPAGE= "http://docbook.sourceforge.net" >> +# Simple persmissive >> +LICENSE = "DSSSL" >> +LIC_FILES_CHKSUM = "file://README;beginline=41;endline=74;md5=875385159b2ee76ecf56136ae7f542d6" > > Oh no! Same comment as other mails... Isn't this a different case? In this situation, there is license information in a section of the README file, which I delineated above. That seems legitimate, as our intention isn't to require upstream sources to include a separate license file. Or is it? >> + >> +DEPENDS = "sgml-common-native" >> + >> +PR = "r0" >> + >> +SRC_URI = "${SOURCEFORGE_MIRROR}/docbook/docbook-dsssl-${PV}.tar.bz2" >> + >> +SRC_URI[md5sum] = "bc192d23266b9a664ca0aba4a7794c7c" >> +SRC_URI[sha256sum] = "2f329e120bee9ef42fbdd74ddd60e05e49786c5a7953a0ff4c680ae6bdf0e2bc" >> + >> +S = "${WORKDIR}/docbook-dsssl-${PV}" >> + >> +inherit native >> + >> +SYSROOT_PREPROCESS_FUNCS += "docbook_dssl_stylesheets_native_mangle" >> + >> +do_install () { >> + # Refer to http://www.linuxfromscratch.org/blfs/view/stable/pst/docbook-dsssl.html >> + # for details. >> + install -d ${D}${bindir} >> + install -m 0755 bin/collateindex.pl ${D}${bindir} >> + >> + install -d ${D}${datadir}/sgml/docbook/dsssl-stylesheets-${PV} >> + install -m 0644 catalog ${D}${datadir}/sgml/docbook/dsssl-stylesheets-${PV} >> + cp -PpRr common ${D}${datadir}/sgml/docbook/dsssl-stylesheets-${PV} >> + >> + install-catalog --add ${sysconfdir}/sgml/dsssl-docbook-stylesheets.cat \ >> + ${D}${datadir}/sgml/docbook/dsssl-stylesheets-${PV}/catalog >> + >> + install-catalog --add ${sysconfdir}/sgml/dsssl-docbook-stylesheets.cat \ >> + ${D}${datadir}/sgml/docbook/dsssl-stylesheets-${PV}/common/catalog >> + >> + install-catalog --add ${sysconfdir}/sgml/sgml-docbook.cat \ >> + ${sysconfdir}/sgml/dsssl-docbook-stylesheets.cat >> + >> + # Moving them to image directory so that they get included in the .ipk file >> + # generated by new style staging. > > Staging isn't ipk files :-) Is this still required? I'll update the comment, but I think we still want to stage the files. Otherwise I noticed that -c cleanall will not remove them from the sysroot. Or is there another way to ensure that? >> + install -d ${D}${sysconfdir}/sgml >> + cp ${sysconfdir}/sgml/dsssl-docbook-stylesheets.cat ${D}${sysconfdir}/sgml/ >> + cp ${sysconfdir}/sgml/sgml-docbook.cat ${D}${sysconfdir}/sgml/ >> + cp ${sysconfdir}/sgml/catalog ${D}${sysconfdir}/sgml/ >> +} >> + >> +docbook_dssl_stylesheets_native_mangle () { >> + # Removing the image directory path ${D} from the .cat file. >> + sed -i -e "s|${D}||g" ${SYSROOT_DESTDIR}${sysconfdir}/sgml/dsssl-docbook-stylesheets.cat >> +} Thanks for the feedback. I'll definitely respin the patch series to include a license file where none exists at all, but this email includes a couple of questions I'd like replies to before I submit it. Thanks, Scott -- Scott Garman Embedded Linux Distro Engineer - Yocto Project Intel Open Source Technology Center