[PATCH] xl: fix broken cpupool-numa-split (part 2)

[Andre Przywara <andre.przywara@amd.com>]

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

On 01/28/2011 07:26 AM, Juergen Gross wrote:
> On 01/27/11 22:36, Andre Przywara wrote:
>> Hi,
>>
>> the implementation of xl cpupool-numa-split is broken. It basically
>> deals with only one poolid, but there are two to consider: the one from
>> the original root CPUpool, the other from the newly created one.
>
> Uhh, silly copy and paste error! I think it happened when I introduced
> libxl_cpupool_cpuadd_node()...
> The correction is much easier. The root poolid is always 0.
Why do you save this value then?
     poolid = poolinfo[0].poolid;
Reading this made me think it can be an arbitrary value.

> See attached patch.
Easier, but that only solves one part of the problem (not populating the 
newly created pool). The second bug still persists, because poolid is 
not zeroed out again after the first creation. So the second iteration 
will try to reuse the just assigned value and abort with an error.

Ian, please apply the attached patch on top of Jürgens one.

----------
Before the creation and population of a new CPU pool we have to clear 
the poolid variable, which still contains the value from the previous 
iteration.
This fixes the execution of xl cpupool-numa-split on machines with more 
than two nodes.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany


[-- Attachment #2: xl_fix_numasplit_missing_poolid_reset.patch --]
[-- Type: text/plain, Size: 502 bytes --]

diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 5af3c21..5c754fc 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -5800,6 +5800,7 @@ int main_cpupoolnumasplit(int argc, char **argv)
 
         snprintf(name, 15, "Pool-node%d", node);
         libxl_uuid_generate(&uuid);
+        poolid = 0;
         ret = -libxl_create_cpupool(&ctx, name, schedid, cpumap, &uuid, &poolid);
         if (ret) {
             fprintf(stderr, "error on creating cpupool\n");

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel