From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v3 0/3] Persist TX SMS messages
Date: Fri, 28 Jan 2011 20:38:36 -0600 [thread overview]
Message-ID: <4D437DAC.1040506@gmail.com> (raw)
In-Reply-To: <1296182397-31963-1-git-send-email-lucas.demarchi@profusion.mobi>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
Hi Lucas,
On 01/27/2011 08:39 PM, Lucas De Marchi wrote:
> Third version. It includes some changes suggested by Denis:
>
> - Get rid of the oldpath field in struct txq_backup_entry
> - Store the encoded uuid in struct txq_backup_entry
> - Use SMS_MSGID_FMT to get the file name
> - Some more cleanups
>
> Lucas De Marchi (3):
> sms: store pending tx pdus on disk
> sms: delete sent sms messages from backup
> sms: restore pending tx messages from backup
>
> src/ofono.h | 1 +
> src/sms.c | 91 ++++++++++++++++++++
> src/smsutil.c | 257 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> src/smsutil.h | 17 ++++
> 4 files changed, 366 insertions(+), 0 deletions(-)
>
I applied all three patches but refactored patch 3 afterwards. In my
testing everything seems to be working nicely and I went ahead and
marked the TODO item as done. Please review my changes to make sure I
didn't break anything.
Regards,
-Denis
prev parent reply other threads:[~2011-01-29 2:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 2:39 [PATCH v3 0/3] Persist TX SMS messages Lucas De Marchi
2011-01-28 2:39 ` [PATCH v3 1/3] sms: store pending tx pdus on disk Lucas De Marchi
2011-01-28 2:39 ` [PATCH v3 2/3] sms: delete sent sms messages from backup Lucas De Marchi
2011-01-28 2:39 ` [PATCH v3 3/3] sms: restore pending tx " Lucas De Marchi
2011-01-29 2:38 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D437DAC.1040506@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.