All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	george0505 <george0505@realtek.com>,
	'Zhaoming_Li' <chaoming_li@realsil.com.cn>
Subject: Re: [RFC/RFT 1/8] rtlwifi: Prepare core for addition of USB driver
Date: Sun, 30 Jan 2011 13:31:02 -0600	[thread overview]
Message-ID: <4D45BC76.1080501@lwfinger.net> (raw)
In-Reply-To: <4D45AEB1.3010207@hauke-m.de>

On 01/30/2011 12:32 PM, Hauke Mehrtens wrote:
> .....
> Now rtlwifi depends on usb (which is missing in KConfig), also when
> using the PCIe chip RTL8192CE. Would it not be better to have one
> interface independent core of rtlwifi as a module and one extra module
> for usb and one for pcie support? I have not looked into the source code
> if it is easily possible to do so.

Actually, RTL8192CE does not depend on USB nor does the implementation prior to
these patches.

I do see a couple of problems with the Kconfig. RTL8192CE needs to have a
dependence on PCI, and RTLWIFI needs to be dependent on RTL8192CE || RTL8192CU.

Sure it would be possible to split rtlwifi into 3 parts. I don't know how much
work it would be, but the lsmod size for all 3 parts together is 113332. If we
take the USB part out, it is 101654. Is this enough of a memory savings once the
additional memory to handle the linkage between the core and the PCI/USB parts
is taken into account?

Thanks,

Larry

  reply	other threads:[~2011-01-30 19:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-30 18:11 [RFC/RFT 0/8] rtl8192cu: Initial upload for comments Larry.Finger
2011-01-30 18:11 ` [RFC/RFT 1/8] rtlwifi: Prepare core for addition of USB driver Larry.Finger
2011-01-30 18:32   ` Hauke Mehrtens
2011-01-30 19:31     ` Larry Finger [this message]
2011-02-03 10:25   ` Stanislaw Gruszka
2011-02-04  4:16     ` Larry Finger
2011-02-04  6:29       ` Stanislaw Gruszka
2011-01-30 18:11 ` [RFC/RFT 2/8] rtl8192cu: Add new driver code - Part 1 Larry.Finger
2011-02-03 10:29   ` Stanislaw Gruszka
2011-01-30 18:11 ` [RFC/RFT 3/8] rtl8192cu: Add new driver code - Part 2 Larry.Finger
2011-02-03 11:28   ` Stanislaw Gruszka
2011-02-03 16:06     ` Larry Finger
2011-01-30 18:11 ` [RFC/RFT 4/8] rtl8192cu: Add new driver code - Part 3 Larry.Finger
2011-01-30 18:11 ` [RFC/RFT 5/8] rtl8192cu: Add new driver code - Part 4 Larry.Finger
2011-01-30 18:11 ` [RFC/RFT 6/8] rtl8192cu: Add new driver code - Part 5 Larry.Finger
2011-01-30 18:11 ` [RFC/RFT 7/8] rtl8192cu: Add new driver code - Part 6 Larry.Finger
2011-01-30 18:11 ` [RFC/RFT 8/8] rtl8192cu: Add new driver code - Part 7 Larry.Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D45BC76.1080501@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=chaoming_li@realsil.com.cn \
    --cc=george0505@realtek.com \
    --cc=hauke@hauke-m.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.