From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 06/24] lv_info handle udev_sync
Date: Sun, 30 Jan 2011 21:17:44 +0100 [thread overview]
Message-ID: <4D45C768.6090306@redhat.com> (raw)
In-Reply-To: <9a4defa6949857ab698f1d25e5779d422c5cdcc6.1296391340.git.zkabelac@redhat.com>
On 01/30/2011 01:57 PM, Zdenek Kabelac wrote:
> NoteII: locking_is_clustered() is needed to detect in which context
> lv_info() is called as we cannot use sync_local_dev_names() when
> locking is not defined.
hmmmm. I probably confused you here:)
I don't think locking_is_clustered() can be used insinde clvmd
(it is "locking implementation" itself).
Or you mean it that in clvmd should run fs_unlock() and in local
code (lvm command) should run sync_local_dev_names(cmd) (with cluster locking)?
> + /*
> + * If open_count info is requested and we have to be sure our own udev
> + * transactions are finished
> + * For non-clustered locking type we are only interested for non-delete operation
> + * in progress - as only those could lead to opened files
> + */
> + if (with_open_count) {
> + if (locking_is_clustered())
> + sync_local_dev_names(cmd); /* Wait to have udev in sync */
> + else if (fs_has_non_delete_ops())
> + fs_unlock(); /* For non clustered - wait if there are non-delete ops */
> + }
this is really ugly...
Milan
next prev parent reply other threads:[~2011-01-30 20:17 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-30 12:57 [PATCH 00/24] Performance improvements Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 01/24] Add find_config_tree_int64 function Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 02/24] Replace PV_MIN_SIZE with function pv_min_size() Zdenek Kabelac
2011-01-30 20:01 ` Milan Broz
2011-01-30 20:15 ` Zdenek Kabelac
2011-01-30 20:22 ` Milan Broz
2011-01-30 21:10 ` Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 03/24] Test pv_min_size functionality Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 04/24] Move add_dev_node to DM_DEVICE_RESUME Zdenek Kabelac
2011-01-31 11:37 ` Peter Rajnoha
2011-01-30 12:57 ` [PATCH 05/24] Perf: Fix multiple operations on the same node Zdenek Kabelac
2011-01-30 19:43 ` Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 06/24] lv_info handle udev_sync Zdenek Kabelac
2011-01-30 20:17 ` Milan Broz [this message]
2011-01-30 20:23 ` Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 07/24] Remove open_count read from some lv_info calls Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 08/24] Perf: optimize _eat_space and _get_token Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 09/24] Align orphan strings Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 10/24] Perf: speed up hash tables Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 11/24] Perf: New HASH function Zdenek Kabelac
2011-01-31 10:33 ` Petr Rockai
2011-01-30 12:57 ` [PATCH 12/24] Perf: Increase hash sizes Zdenek Kabelac
2011-01-30 20:35 ` Milan Broz
2011-01-30 20:54 ` Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 13/24] Memory unlock allows 1 page difference Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 14/24] Critical section Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 15/24] Remove fs_unlock after failed suspend Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 16/24] Man pages reformating Zdenek Kabelac
2011-01-30 20:37 ` Milan Broz
2011-01-30 12:57 ` [PATCH 17/24] Void* arithmetic replaced with char* Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 18/24] API change - support more const arg Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 19/24] Use cleaner const * pointer Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 20/24] Const fixing Zdenek Kabelac
2011-01-30 20:44 ` Milan Broz
2011-01-30 12:57 ` [PATCH 21/24] Testing: remove -q from grep Zdenek Kabelac
2011-01-30 20:50 ` Milan Broz
2011-01-30 12:57 ` [PATCH 22/24] Testing: Try to prioritize locking process Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 23/24] Extend lvm2api with lvm_lv_rename Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 24/24] Testing lvm_lv_rename Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D45C768.6090306@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.