From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH] xl: fix broken cpupool-numa-split (part 2) Date: Mon, 31 Jan 2011 07:56:27 +0100 Message-ID: <4D465D1B.1010504@ts.fujitsu.com> References: <4D41E547.5000902@amd.com> <4D426189.1030001@ts.fujitsu.com> <4D4360EA.1090807@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4D4360EA.1090807@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andre Przywara Cc: George Dunlap , "xen-devel@lists.xensource.com" , Ian Jackson List-Id: xen-devel@lists.xenproject.org On 01/29/11 01:35, Andre Przywara wrote: > On 01/28/2011 07:26 AM, Juergen Gross wrote: >> On 01/27/11 22:36, Andre Przywara wrote: >>> Hi, >>> >>> the implementation of xl cpupool-numa-split is broken. It basically >>> deals with only one poolid, but there are two to consider: the one fr= om >>> the original root CPUpool, the other from the newly created one. >> >> Uhh, silly copy and paste error! I think it happened when I introduced >> libxl_cpupool_cpuadd_node()... >> The correction is much easier. The root poolid is always 0. > Why do you save this value then? > poolid =3D poolinfo[0].poolid; > Reading this made me think it can be an arbitrary value. Sorry, must be a relict... > >> See attached patch. > Easier, but that only solves one part of the problem (not populating th= e > newly created pool). The second bug still persists, because poolid is > not zeroed out again after the first creation. So the second iteration > will try to reuse the just assigned value and abort with an error. > > Ian, please apply the attached patch on top of J=FCrgens one. > > ---------- > Before the creation and population of a new CPU pool we have to clear > the poolid variable, which still contains the value from the previous > iteration. > This fixes the execution of xl cpupool-numa-split on machines with more > than two nodes. > > Signed-off-by: Andre Przywara Acked-by: juergen.gross@ts.fujitsu.com --=20 Juergen Gross Principal Developer Operating Systems TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujits= u.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.= html