From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Huang <wei.huang2@amd.com>
Subject: Re: [PATCH][SVM] Fix 32bit Windows guest VMs save/restore
Date: Mon, 31 Jan 2011 15:43:10 -0600
Message-ID: <4D472CEE.6060802@amd.com>
References: <C96CE57D.165CF%keir@xen.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C96CE57D.165CF%keir@xen.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir@xen.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "james.harper@bendigoit.com.au" <james.harper@bendigoit.com.au>
List-Id: xen-devel@lists.xenproject.org

This is true. I thought about it. Some problematic code path can be 
"enter 32bit mode => execute sysenter => turn on long mode" (or vice 
versa). In this case, SYSENTER MSRs should be copied from VMCB to vcpu 
fields. But current Xen doesn't do so.

-Wei

On 01/31/2011 03:17 PM, Keir Fraser wrote:
>   suspect the current approach has
> further bugs because I don't believe the canonical sysenter msr values are
> correctly shuffled between the vmcb and vcpu structures