All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] netfilter: ecache: always set events bits,	filter them later
Date: Tue, 01 Feb 2011 16:09:29 +0100	[thread overview]
Message-ID: <4D482229.6000707@trash.net> (raw)
In-Reply-To: <20110201120547.3427.21721.stgit@decadence>

Am 01.02.2011 13:05, schrieb Pablo Neira Ayuso:
> For the following rule:
> 
> iptables -I PREROUTING -t raw -j CT --ctevents assured
> 
> The event delivered looks like the following:
> 
>  [UPDATE] tcp      6 src=192.168.0.2 dst=192.168.1.2 sport=37041 dport=80 src=192.168.1.2 dst=192.168.1.100 sport=80 dport=37041 [ASSURED]
> 
> Note that the TCP protocol state is not included. For that reason
> the CT event filtering is not very useful for conntrackd.
> 
> To resolve this issue, instead of conditionally setting the CT events
> bits based on the ctmask, we always set them and perform the filtering
> in the late stage, just before the delivery.
> 
> Thus, the event delivered looks like the following:
> 
>  [UPDATE] tcp      6 432000 ESTABLISHED src=192.168.0.2 dst=192.168.1.2 sport=37041 dport=80 src=192.168.1.2 dst=192.168.1.100 sport=80 dport=37041 [ASSURED]
> 

Looks good to me, applied, thanks. Do you want me to push this
one to -stable as well?

  reply	other threads:[~2011-02-01 15:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01 12:05 [PATCH 0/2] bugfixes for nf-next-2.6 (2.6.38-rc) Pablo Neira Ayuso
2011-02-01 12:05 ` [PATCH 1/2] netfilter: arpt_mangle: fix return values of checkentry Pablo Neira Ayuso
2011-02-01 15:04   ` Patrick McHardy
2011-02-01 12:05 ` [PATCH 2/2] netfilter: ecache: always set events bits, filter them later Pablo Neira Ayuso
2011-02-01 15:09   ` Patrick McHardy [this message]
2011-02-01 12:45 ` [PATCH 0/2] bugfixes for nf-next-2.6 (2.6.38-rc) Patrick McHardy
2011-02-01 12:47   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D482229.6000707@trash.net \
    --to=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.