From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] voicecall: try harder to avoid Dial mismatches
Date: Tue, 01 Feb 2011 19:24:50 -0600 [thread overview]
Message-ID: <4D48B262.8060006@gmail.com> (raw)
In-Reply-To: <1296598930-3093-2-git-send-email-Pekka.Pessi@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
Hi Pekka,
On 02/01/2011 04:22 PM, Pekka.Pessi(a)nokia.com wrote:
> From: Pekka Pessi <Pekka.Pessi@nokia.com>
>
> There were some cases where Dial returned an incorrect call object,
> e.g., after oFono crash and recover.
> ---
> src/voicecall.c | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
So I'm guessing that you're restarting oFono and get
ofono_voicecall_notify events without setting dial_result_handled properly.
Do you think it is a better idea to resurrect the old list_calls driver
method and fire this off explicitly when the atom is registered? The
callback can then take care of setting dial_result_handled appropriately.
Regards,
-Denis
next prev parent reply other threads:[~2011-02-02 1:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 22:22 [PATCH 1/2] isimodem: fix problems in call state reporting Pekka.Pessi
2011-02-01 22:22 ` [PATCH 2/2] voicecall: try harder to avoid Dial mismatches Pekka.Pessi
2011-02-02 1:24 ` Denis Kenzior [this message]
2011-02-02 14:57 ` Pekka Pessi
2011-02-02 16:41 ` Denis Kenzior
2011-02-03 13:01 ` [PATCH 1/2] isimodem: fix problems in call state reporting Aki Niemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D48B262.8060006@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.