All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC] voice call API changes (proposal)
Date: Wed, 02 Feb 2011 09:32:28 -0600	[thread overview]
Message-ID: <4D49790C.4010807@gmail.com> (raw)
In-Reply-To: <4D490D17.3040405@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]

Hi Andras,

On 02/02/2011 01:51 AM, Andras Domokos wrote:
> Hi Denis,
> 
> On 02/01/2011 05:54 PM, ext Denis Kenzior wrote:
>> Hi Andras,
>>
>>>>> +
>>>>> +        boolean Forwarded
>>>>> +
>>>>> +            Contains the indication whether the voice call is a
>>>>> +            forwarded call or not.
>>>>> +
>>>> So just to clarify, this is usually set on a local Incoming / Waiting
>>>> call, correct?
>>> This property would apply to both, outgoing and incoming calls.
>>>
>>> When the incoming call is a forwarded call the call is accompanied
>>> by a "forwarded call" SS notification.
>>>
>>> When the call is an outgoing call and the call is forwarded due to the
>>> remote party having a conditional or unconditional forwarding enabled,
>>> the outgoing call is accompanied by a "call has been forwarded"
>>> SS notification.
>>>
>>> I think would be a good idea, if not mandatory, to have a voice call
>>> property indicating the call direction.
>> So why do we need the below two signals if the Forwarded property
>> applies to both incoming and outgoing calls?
> These are optional in fact, let's ignore them for now.
> What about the rest, are we OK now?

I don't really like this Forwarded property.  I think we should really
break up the indications between the Incoming and Outgoing states.  If
you want Forwarded as a property, then treat it as incoming calls only
and keep the two signals for the outgoing conditions.

Please re-send the entire proposal with all the feedback and extra
documentation integrated in so we can have another look.

Regards,
-Denis

  reply	other threads:[~2011-02-02 15:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1296474033.git.Andras.Domokos@nokia.com>
2011-01-31 11:56 ` [RFC] voice call API changes (proposal) Andras Domokos
2011-01-31 19:58   ` Denis Kenzior
2011-02-01 15:43     ` Andras Domokos
2011-02-01 15:54       ` Denis Kenzior
2011-02-02  7:51         ` Andras Domokos
2011-02-02 15:32           ` Denis Kenzior [this message]
2011-02-02 18:16             ` [RFC] voicecall API changes (proposal 2) Andras Domokos
2011-02-02 20:01               ` Denis Kenzior
2011-02-03 10:53                 ` Andras Domokos
2011-02-03 16:29                   ` Denis Kenzior
2011-02-07 11:18                     ` [RFC] voicecall API changes (proposal v3) Andras Domokos
2011-02-07 16:38                       ` Denis Kenzior
2011-02-07 17:07                         ` Andras Domokos
2011-02-07 17:09                         ` Andras Domokos
2011-02-07 19:39                           ` Denis Kenzior
2011-02-08  8:55                             ` Andras Domokos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D49790C.4010807@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.