All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nick Piggin <npiggin@suse.de>
Subject: Re: Problem found, but why???
Date: Wed, 02 Feb 2011 20:46:52 +0200	[thread overview]
Message-ID: <4D49A69C.4040801@panasas.com> (raw)
In-Reply-To: <4D498ADC.4060306@panasas.com>

115e19c53501edc11f730191f7f047736815ae3d is the first bad commit
commit 115e19c53501edc11f730191f7f047736815ae3d
Author: Boaz Harrosh <Boaz Harrosh bharrosh@panasas.com>

    exofs: Set i_mapping->backing_dev_info anyway

OK It's stupid ME. But why please someone explain this issue?
For now I'll send a revert, but I would like this explained,
perhaps a more solid fix is needed.

Please look at this patch:

diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c
index 24ab327..0ba9886 100644
--- a/fs/exofs/inode.c
+++ b/fs/exofs/inode.c
@@ -1030,6 +1030,7 @@ struct inode *exofs_iget(struct super_block *sb, unsigned long ino)
 		memcpy(oi->i_data, fcb.i_data, sizeof(fcb.i_data));
 	}
 
+	inode->i_mapping->backing_dev_info = sb->s_bdi;
 	if (S_ISREG(inode->i_mode)) {
 		inode->i_op = &exofs_file_inode_operations;
 		inode->i_fop = &exofs_file_operations;
@@ -1129,6 +1130,7 @@ struct inode *exofs_new_inode(struct inode *dir, int mode)
 
 	sbi = sb->s_fs_info;
 
+	inode->i_mapping->backing_dev_info = sb->s_bdi;
 	sb->s_dirt = 1;
 	inode_init_owner(inode, dir, mode);
 	inode->i_ino = sbi->s_nextid++;


All it does is set the inode's bdi to point to the super-block bdi. In stead
of this default "null" bdi from VFS. When we do so the read-ahead stops
coming, completely. Is there something that needs to be implemented farther
for a super-block's bdi to support read-ahead? Please help?

Thanks
Boaz

  reply	other threads:[~2011-02-02 18:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02 16:48 Please Help: 2.6.37 a_ops->readpages is never called, 2.6.36 was fine Boaz Harrosh
2011-02-02 18:46 ` Boaz Harrosh [this message]
2011-02-02 21:51   ` Problem found, but why??? Chris Mason
2011-02-03 11:22 ` [PATCH] exofs: Fix read ahead BUG, caused by moving inodes to sb->s_bdi Boaz Harrosh
2011-02-03 12:12   ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D49A69C.4040801@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=npiggin@suse.de \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.