Am 02.02.2011 20:52, schrieb Jozsef Kadlecsik:
> Hi Patrick,
> 
> On Wed, 2 Feb 2011, Patrick McHardy wrote:
> 
>> Add some #ifdefs to unconditionally return false in
>> ip_set_get_ip6_port() when CONFIG_IPV6=n and convert
>> to ipv6_skip_exthdr() to avoid pulling in the ip6_tables
>> module when loading ipset.
> 
> You left out checking fragmented packets. Is it intentional?

Yes, ipv6_skip_exthdr() returns an error for non-first fragments.
For the first fragment skb_header_pointer() checks that enough
data for the port numbers is present.

>> A slightly more code-saving alternative would be to add
>> a dummy inline function or ifdef the callsites. Please
>> let me know which way you prefer.
> 
> A dummy inline looks nicer to me, because that way the IPv6 and non-IPv6 
> cases were clearly separated.

OK, I'm going to commit this patch.