From: Mike Christie <michaelc@cs.wisc.edu>
To: Bhanu Gollapudi <bprakash@broadcom.com>
Cc: "devel@open-fcoe.org" <devel@open-fcoe.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Michael Chan <mchan@broadcom.com>
Subject: Re: [v2 PATCH 4/5] bnx2fc: Broadcom FCoE Offload driver submission - part 2
Date: Wed, 02 Feb 2011 22:05:53 -0600 [thread overview]
Message-ID: <4D4A29A1.7010105@cs.wisc.edu> (raw)
In-Reply-To: <1296704558.268.552.camel@LTLNR-SJCE10.corp.ad.broadcom.com>
On 02/02/2011 09:42 PM, Bhanu Gollapudi wrote:
>>
>> Actually you do not have to wait for the scsi eh to run, right. It
>> looks
>> like bnx2fc would log out the port, which ends up calling
>> fc_remote_port_delete and that would cause the fc timed out function
>> to
>> return BLK_EH_RESET_TIMER to prevent the scsi eh from running. Is
>> that
>> right? That type of eh strategy behavior seems like something you
>> want
>> to sync up with libfc or the fc class so all drivers do something
>> similar.
>
> As per FCP-4, if the ABTS times out, we will have to explicitly LOGO the
What section is that in?
> target and relogin back. If we rely on 60 sec eh_abort_handler, and if
> ABTS times out, SCSI error handling will go to LUN RESET, TGT reset
> path, which is a generic error handling than transport specific error
> handling.
If that is right, then it seems the other FC drivers are doing it wrong
then, and you hit that problem if someone sets the scsi cmd timer lower
than BNX2FC_IO_TIMEOUT. If that is right, that just does not seem right
to hack around the issue in the driver too.
next prev parent reply other threads:[~2011-02-03 4:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-24 6:02 [v2 PATCH 4/5] bnx2fc: Broadcom FCoE Offload driver submission - part 2 Bhanu Gollapudi
2011-01-15 9:17 ` Mike Christie
2011-01-18 0:37 ` Bhanu Gollapudi
2011-02-02 9:24 ` Mike Christie
2011-02-02 9:57 ` [Open-FCoE] " Mike Christie
2011-02-03 3:42 ` Bhanu Gollapudi
2011-02-03 4:05 ` Mike Christie [this message]
2011-02-03 4:16 ` [Open-FCoE] " Mike Christie
2011-02-03 4:47 ` Mike Christie
2011-02-03 7:04 ` Bhanu Gollapudi
2011-02-03 20:55 ` Mike Christie
2011-02-03 21:02 ` Mike Christie
2011-02-03 21:26 ` Mike Christie
2011-01-18 2:44 ` Mike Christie
2011-01-18 3:29 ` Bhanu Gollapudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4A29A1.7010105@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=bprakash@broadcom.com \
--cc=devel@open-fcoe.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mchan@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.