From: Bernhard Walle <walle@corscience.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: dbrownell@users.sourceforge.net,
spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
arnd@arndb.de
Subject: Re: [PATCH] spi: spidev: Add 32 bit compat ioctl()
Date: Thu, 03 Feb 2011 09:38:06 +0100 [thread overview]
Message-ID: <4D4A696E.4050302@corscience.de> (raw)
In-Reply-To: <AANLkTikbXYxyUmBsPNO6mxB2x_4Qr49BQZTKrqvsiK8a@mail.gmail.com>
Am 02.02.2011 15:15, schrieb Grant Likely:
>> static int spidev_open(struct inode *inode, struct file *filp)
>> {
>> struct spidev_data *spidev;
>> @@ -543,6 +552,9 @@ static const struct file_operations spidev_fops = {
>> .write = spidev_write,
>> .read = spidev_read,
>> .unlocked_ioctl = spidev_ioctl,
>> +#ifdef CONFIG_COMPAT
>> + .compat_ioctl = spidev_compat_ioctl,
>> +#endif
>
> Then the #ifdef/#endif can be dropped here which is tidier.
Ok, thanks, I resent the patch with that modification.
Regards,
Bernhard
next prev parent reply other threads:[~2011-02-03 8:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 11:31 [PATCH] spi: spidev: Add 32 bit compat ioctl() Bernhard Walle
2011-02-02 12:18 ` Arnd Bergmann
2011-02-02 14:15 ` Grant Likely
2011-02-03 8:38 ` Bernhard Walle [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-03 8:37 Bernhard Walle
2011-02-03 16:56 ` Grant Likely
2011-02-02 11:30 Bernhard Walle
2011-02-02 10:57 Bernhard Walle
2011-02-02 11:15 ` Arnd Bergmann
2011-02-02 11:32 ` Bernhard Walle
2011-02-02 10:56 y
2011-02-02 10:56 Unknown, y
2011-02-02 10:56 y
2011-02-01 9:02 Bernhard Walle
2011-02-02 4:39 ` Grant Likely
2011-02-02 9:37 ` Arnd Bergmann
2011-02-02 10:56 ` Bernhard Walle
2011-02-02 14:12 ` Grant Likely
2011-01-11 15:32 Bernhard Walle
2010-12-01 10:51 Bernhard Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4A696E.4050302@corscience.de \
--to=walle@corscience.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.