Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

[Andreas WESTIN <andreas.westin@stericsson.com>]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

Hi Aki,

On 2011-02-02 14:03, Aki Niemi wrote:
> I don't see what that has to do with the device supporting the "PC
> suite" USB profile, which allows modem access using cdc_phonet.

Currently our platform does not support this.

> That is exactly what I meant. This version allows building quirks inside
> the drivers. An example in pseudo-code:
>
> if GIsiVersion.major == 15 and GIsiVersion.minor>= 3:
> 	send( { FOO, value, filler, filler}, callback1 )
> else:
> 	send( { FOO, value }, callback2 )
>

Yes, we use a similar solution in gisi, but Rémi pointed out that it 
would be a maintenance problem once there are more versions to support 
and I tend to agree. A solution could be to use a lookup function, but 
this function would need to return something to compare with, an enum 
perhaps.
Also are you certain that e.g major == 15 and minor == 25 is still the 
same ISI version, if not then the lookup function could become messy.

Regards
Andreas