From: Jan Kiszka <jan.kiszka@web.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] checkpatch.pl: don't complain about old lines with tabs
Date: Thu, 03 Feb 2011 22:50:08 +0100 [thread overview]
Message-ID: <4D4B2310.5090803@web.de> (raw)
In-Reply-To: <AANLkTimcaCvEM_87PfFhR39h139CyeU=kJ4SYtqx_V4C@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On 2011-02-03 18:55, Blue Swirl wrote:
> Don't complain when the patch includes lines with tabs
> only in the hunk's untouched context.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 4fa06c0..075b614 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1495,7 +1495,7 @@ sub process {
> next if ($realfile !~ /\.(h|c|pl)$/);
>
> # in QEMU, no tabs are allowed
> - if ($rawline =~ /\t/) {
> + if ($rawline =~ /^\+.*\t/) {
> my $herevet = "$here\n" . cat_vet($rawline) . "\n";
> ERROR("code indent should never use tabs\n" . $herevet);
> $rpt_cleaners = 1;
> -- 1.6.2.4
Works perfectly now.
Thanks,
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
prev parent reply other threads:[~2011-02-03 21:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 17:55 [Qemu-devel] [PATCH] checkpatch.pl: don't complain about old lines with tabs Blue Swirl
2011-02-03 21:50 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4B2310.5090803@web.de \
--to=jan.kiszka@web.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.