From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Hans Schillstrom <hans.schillstrom@ericsson.com>,
"jengelh@medozas.de" <jengelh@medozas.de>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"hans@schillstrom.com" <hans@schillstrom.com>
Subject: Re: [PATCH] NETFILTER module xt_hmark new target for HASH MARK
Date: Fri, 04 Feb 2011 14:20:05 +0100 [thread overview]
Message-ID: <4D4BFD05.6030003@trash.net> (raw)
In-Reply-To: <4D4ACCCB.8030902@netfilter.org>
On 03.02.2011 16:42, Pablo Neira Ayuso wrote:
> On 03/02/11 15:23, Hans Schillstrom wrote:
>>> If this is accepted, I think this has to be merge with the (already
>>> overloaded) MARK target.
>>
>> I have no opinion about that, others might have.
>
> Better put it in the MARK target with a new revision. I think that
> Patrick is going to ask you this.
>
> I don't know why I had the impression that MARK is overload, it's
> actually fine at a first glance to the code.
I don't think we should merge this with the MARK target, I don't
want to bloat the simple mark structure with all the parameters
needed for this module.
next prev parent reply other threads:[~2011-02-04 13:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 13:34 [PATCH 0/2] NETFILTER new target module, HMARK Hans Schillstrom
2011-02-03 13:34 ` [PATCH] NETFILTER module xt_hmark new target for HASH MARK Hans Schillstrom
2011-02-03 13:51 ` Pablo Neira Ayuso
2011-02-03 14:23 ` Hans Schillstrom
2011-02-03 15:42 ` Pablo Neira Ayuso
2011-02-03 16:01 ` Pablo Neira Ayuso
2011-02-03 16:06 ` Jan Engelhardt
2011-02-03 16:08 ` Pablo Neira Ayuso
2011-02-03 16:32 ` Jan Engelhardt
2011-02-03 17:40 ` Hans Schillstrom
2011-02-03 17:37 ` Hans Schillstrom
2011-02-04 13:17 ` Patrick McHardy
2011-02-04 13:20 ` Patrick McHardy [this message]
2011-02-03 13:34 ` [PATCH] NETFILTER userspace part for target HMARK Hans Schillstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4BFD05.6030003@trash.net \
--to=kaber@trash.net \
--cc=hans.schillstrom@ericsson.com \
--cc=hans@schillstrom.com \
--cc=jengelh@medozas.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.