Re: [oe-commits] Martin Jansa : gnu-config: update also bindir change to replace /usr/bin/ env instead of /usr/bin/perl

Re: [oe-commits] Martin Jansa : gnu-config: update also bindir change to replace /usr/bin/ env instead of /usr/bin/perl

[Tom Rini]

On 02/04/2011 08:11 AM, git version control wrote:
> Module: openembedded.git
> Branch: master
> Commit: edcdefbf6e0675c1bcc1fc4f464f654223380e50
> URL:    http://gitweb.openembedded.net/?p=openembedded.git&a=commit;h=edcdefbf6e0675c1bcc1fc4f464f654223380e50
>
> Author: Martin Jansa<Martin.Jansa@gmail.com>
> Date:   Fri Feb  4 16:11:25 2011 +0100
>
> gnu-config: update also bindir change to replace /usr/bin/env instead of /usr/bin/perl
>
> Signed-off-by: Martin Jansa<Martin.Jansa@gmail.com>

This is wrong.  /usr/bin/env is one of those mandated things everyone 
has.  And ${bindir} can be too long :)  Based on the previous commit, 
this test/regex should be able to go away.

-- 
Tom Rini
Mentor Graphics Corporation

Re: [oe-commits] Martin Jansa : gnu-config: update also bindir change to replace /usr/bin/ env instead of /usr/bin/perl

[Otavio Salvador]

On Fri, Feb 4, 2011 at 15:30, Tom Rini <tom_rini@mentor.com> wrote:
> On 02/04/2011 08:11 AM, git version control wrote:
...
>> gnu-config: update also bindir change to replace /usr/bin/env instead of
>> /usr/bin/perl
...
> This is wrong.  /usr/bin/env is one of those mandated things everyone has.
>  And ${bindir} can be too long :)  Based on the previous commit, this
> test/regex should be able to go away.

This is right since micro can build without /usr et all.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [oe-commits] Martin Jansa : gnu-config: update also bindir change to replace /usr/bin/ env instead of /usr/bin/perl

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

On Fri, Feb 04, 2011 at 03:57:37PM +0000, Otavio Salvador wrote:
> On Fri, Feb 4, 2011 at 15:30, Tom Rini <tom_rini@mentor.com> wrote:
> > On 02/04/2011 08:11 AM, git version control wrote:
> ...
> >> gnu-config: update also bindir change to replace /usr/bin/env instead of
> >> /usr/bin/perl
> ...
> > This is wrong.  /usr/bin/env is one of those mandated things everyone has.
> >  And ${bindir} can be too long :)  Based on the previous commit, this
> > test/regex should be able to go away.
> 
> This is right since micro can build without /usr et all.

yes and ${bindir} is not that long :), only /usr/bin or like Otavio said
/bin ie for micro. That's why I fixed regexp instead of removing it.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Type: application/pgp-signature, Size: 205 bytes --]

Re: [oe-commits] Martin Jansa : gnu-config: update also bindir change to replace /usr/bin/ env instead of /usr/bin/perl

[Tom Rini]

On 02/04/2011 08:57 AM, Otavio Salvador wrote:
> On Fri, Feb 4, 2011 at 15:30, Tom Rini<tom_rini@mentor.com>  wrote:
>> On 02/04/2011 08:11 AM, git version control wrote:
> ...
>>> gnu-config: update also bindir change to replace /usr/bin/env instead of
>>> /usr/bin/perl
> ...
>> This is wrong.  /usr/bin/env is one of those mandated things everyone has.
>>   And ${bindir} can be too long :)  Based on the previous commit, this
>> test/regex should be able to go away.
>
> This is right since micro can build without /usr et all.

OK, you're right.  But that comment is unclear :)

-- 
Tom Rini
Mentor Graphics Corporation