Hi Mikhail,

On 02/04/2011 12:52 PM, mikhail.zabaluev(a)nokia.com wrote:
> Hi,
> 
>> -----Original Message-----
>> From: ofono-bounces(a)ofono.org [mailto:ofono-bounces(a)ofono.org] On
>> Behalf Of ext Marcel Holtmann
>> Sent: Friday, February 04, 2011 8:13 PM
>> To: ofono(a)ofono.org
>> Subject: RE: [RFC 2/2] doc: Add description for history agent interface
>>
>>> Why, you already cache fragments by their respective message refs
>> efficiently.
>>> The only thing missing is a thin API to provide a view on complete
>> messages.
>>
>> we are not storing the complete message. We give it to the history API.
> 
> Somehow we never got to the "because" part in this discussion. Or is it a dogma in oFono?
>

Because we wanted to avoid this exact discussion.  If you want some
particular API for text messaging, feel free to implement it.
Everything you need is provided.  The sms assembly / status assembly
code will not help you in any way here.

> 
> Sorry, I only jumped into the discussion after it has started and did not read the patch.
> But now that I do, I see an additional AddMatch and a GetOwnerName in this flow.
> 
> And the failure mode of the agent disconnecting is... to drop events on the floor???
> 

Then please take the hint and get more background first.  Marcel did
mention in the thread that his patch is an RFC (he is a maintainer after
all) and that spooling of messages when the agent is not registered is
still not done.

Regards,
-Denis