Re: [RFC] --dump-sym-trace

[David Ahern <daahern@cisco.com>]

On 02/04/11 18:48, Arun Sharma wrote:
> On Sat, Jan 29, 2011 at 12:50 PM, Arnaldo Carvalho de Melo
> <acme@ghostprotocols.net> wrote:
>> /me too
>>
>> I have to get back to that, it is definetely a feature we need to have.
> 
> There are a couple of more minor nits I found in David's patch:
> 
> * perf record --timehist doesn't seem to be doing anything. I used
> perf record -T -a.

For record the the --timehist flag adds the timestamp and cpu to the IP
samples -- hidden attributes from a 'perf report' perspective unless you
add the --timehist flag on the report as well in which case the output
is completely different.

I take it your mileage varied from the above.

David



> * Some of the printfs are missing checks along the lines of:
> 
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -228,6 +228,7 @@ static int perf_session__print_sample(struct
> perf_session *session,
>                 free(syms);
> 
>         } else {
> +               if (!data || !al || !al->thread || !al->sym ||
> !al->map) return 0;
>                 printf(TIMEHIST_FMT,
>                            tstr, data->cpu,
>                            al->thread->comm, al->thread->pid, al->addr,
> 
> to avoid SIGSEGVs when the information in the sample is incomplete.
> 
>  -Arun