All of lore.kernel.org
 help / color / mirror / Atom feed
From: Coly Li <i@coly.li>
To: linux-ext4@vger.kernel.org
Cc: Alex Tomas <alex@clusterfs.com>, Theodore Tso <tytso@google.com>
Subject: [PATCH 3/5] mballoc: add comments to ext4_mb_mark_free_simple()
Date: Sun, 06 Feb 2011 12:54:00 +0800	[thread overview]
Message-ID: <4D4E2968.5010308@coly.li> (raw)

This patch tries to add comments to make ext4_mb_mark_free_simple more
readable.

Signed-off-by: Coly Li <bosong.ly@taobao.com>
Cc: Alex Tomas <alex@clusterfs.com>
Cc: Theodore Tso <tytso@google.com>
---
  fs/ext4/mballoc.c |    7 ++++++-
  1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 458dce0..c5534f4 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -630,7 +630,12 @@ static int __mb_check_buddy(struct ext4_buddy *e4b, char *file,
  #define mb_check_buddy(e4b)
  #endif

-/* FIXME!! need more doc */
+/*
+ * Devide blocks started from @first with length @len into
+ * smaller chunks with power of 2 blocks.
+ * Clear the bits in bitmap which the blocks of the chunk(s) covered,
+ * then increase bb_counters[] for corresponded chunk size.
+ */
  static void ext4_mb_mark_free_simple(struct super_block *sb,
  				void *buddy, ext4_grpblk_t first, ext4_grpblk_t len,
  					struct ext4_group_info *grp)
-- 
1.7.3.4

             reply	other threads:[~2011-02-06  4:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-06  4:54 Coly Li [this message]
2011-02-24 19:07 ` [PATCH 3/5] mballoc: add comments to ext4_mb_mark_free_simple() Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D4E2968.5010308@coly.li \
    --to=i@coly.li \
    --cc=alex@clusterfs.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.