From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 02/12] gprs: driver interface changes for IPv6
Date: Mon, 07 Feb 2011 10:32:14 -0600 [thread overview]
Message-ID: <4D501E8E.4020100@gmail.com> (raw)
In-Reply-To: <CB0EE8641411214CBAFF8AEBB26ABCEC2985A8@008-AM1MPN1-001.mgdnok.nokia.com>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
Hi Mika,
On 02/07/2011 03:55 AM, Mika.Liljeberg(a)nokia.com wrote:
> Hi Denis,
>
> Thanks for the comments.
>
>>> +enum ofono_gprs_addrconf {
>>> + OFONO_GPRS_ADDRCONF_NONE,
>>> + OFONO_GPRS_ADDRCONF_STATIC,
>>> + OFONO_GPRS_ADDRCONF_DHCP,
>>> +};
>>> +
>>
>> What exactly is the _NONE addrconf for? And why don't we use
>> a gboolean
>> here like before?
>
> Neither "static" nor "DHCP" makes sense for IPv6. If we have an IPv6 only context, the "Method" property will not show up at all.
What about combined V4 V6 contexts? What method do you use there, since
NONE doesn't exactly fit? I'd rather see this be ignored for IPv6
contexts or that we separate the IPv4 and IPv6 configuration into two
separate batches.
Regards,
-Denis
next prev parent reply other threads:[~2011-02-07 16:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 9:03 [PATCH 0/12] IPv6 support Mika Liljeberg
2011-02-03 9:03 ` [PATCH 01/12] gprs: Update documentation for IPv6 Mika Liljeberg
2011-02-03 9:03 ` [PATCH 02/12] gprs: driver interface changes " Mika Liljeberg
2011-02-04 17:24 ` Denis Kenzior
2011-02-07 9:55 ` Mika.Liljeberg
2011-02-07 16:32 ` Denis Kenzior [this message]
2011-02-08 8:55 ` Mika.Liljeberg
2011-02-07 19:09 ` Marcel Holtmann
2011-02-08 8:36 ` Mika.Liljeberg
2011-02-03 9:03 ` [PATCH 03/12] gprs: core support " Mika Liljeberg
2011-02-04 17:50 ` Denis Kenzior
2011-02-07 10:12 ` Mika.Liljeberg
2011-02-03 9:03 ` [PATCH 04/12] test: modify test scripts " Mika Liljeberg
2011-02-03 9:03 ` [PATCH 05/12] isimodem: IPv6 support Mika Liljeberg
2011-02-03 9:03 ` [PATCH 06/12] atmodem: update to new gprs context interface Mika Liljeberg
2011-02-03 9:03 ` [PATCH 07/12] huaweimodem: " Mika Liljeberg
2011-02-03 9:03 ` [PATCH 08/12] mbmmodem: " Mika Liljeberg
2011-02-03 9:03 ` [PATCH 09/12] hsomodem: " Mika Liljeberg
2011-02-03 9:03 ` [PATCH 10/12] ifxmodem: " Mika Liljeberg
2011-02-03 9:03 ` [PATCH 11/12] stemodem: " Mika Liljeberg
2011-02-03 9:03 ` [PATCH 12/12] phonesim: add IPv6 support Mika Liljeberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D501E8E.4020100@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.