From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57138 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PmUIu-0005bf-25 for qemu-devel@nongnu.org; Mon, 07 Feb 2011 11:51:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PmUIp-0006w2-KG for qemu-devel@nongnu.org; Mon, 07 Feb 2011 11:51:04 -0500 Received: from eu1sys200aog115.obsmtp.com ([207.126.144.139]:37881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PmUIp-0006vx-Bc for qemu-devel@nongnu.org; Mon, 07 Feb 2011 11:51:03 -0500 Message-ID: <4D5022E6.4040704@st.com> Date: Mon, 7 Feb 2011 17:50:46 +0100 From: Christophe Lyon MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 6/8] target-arm: Fix Neon VQ(R)SHRN instructions. References: <1296497206-15643-1-git-send-email-christophe.lyon@st.com> <1296497206-15643-7-git-send-email-christophe.lyon@st.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "qemu-devel@nongnu.org" On 07.02.2011 17:08, Peter Maydell wrote: > On 31 January 2011 18:06, wrote: >> From: Christophe Lyon >> >> Handle unsigned variant of VQ(R)SHRN instructions. > > This patch appears to be modifying a section of code > that was already patched by 2/8 in this series. That's > too confusing to review -- please combine them into > one patch. > That's because I borrowed patch 2/8 from your meego tree. It was incomplete, but as I preferred to keep it as-is, I completed it in a separate patch. >>From your other comments it looks like I'd have had better ignore the patches from Meego and rewrite the patches on my own ;-)