From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Zachary Amsden <zamsden@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: x86: Convert tsc_write_lock to raw_spinlock
Date: Mon, 07 Feb 2011 19:10:57 +0200 [thread overview]
Message-ID: <4D5027A1.8000505@redhat.com> (raw)
In-Reply-To: <4D5024F3.9090105@siemens.com>
On 02/07/2011 06:59 PM, Jan Kiszka wrote:
> >
> > (well, actually, cpufreq_notifier and kvm_arch_hardware_enable are
> > already non preemptible, and the stats code should just go away?)
>
> The stats code is trivial to convert, so it doesn't matter.
Removal is easier.
> But what about mmu_shrink and its list_move_tail? How is this
> synchronized against kvm_destroy_vm - already today?
kvm_destroy_vm() takes kvm_lock. If a vm is destroyed before
mmu_shrink(), mmu_shrink() will never see it. If we reach mmu_shrink()
before kvm_destroy_vm(), the latter will wait until mmu_shrink() is done.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-02-07 17:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 9:49 [PATCH] KVM: x86: Convert tsc_write_lock to raw_spinlock Jan Kiszka
2011-02-04 21:03 ` Zachary Amsden
2011-02-07 11:35 ` Jan Kiszka
2011-02-07 14:11 ` Zachary Amsden
2011-02-07 15:00 ` Jan Kiszka
2011-02-07 15:15 ` Zachary Amsden
2011-02-07 15:38 ` Jan Kiszka
2011-02-07 15:52 ` Avi Kivity
2011-02-07 15:58 ` Jan Kiszka
2011-02-07 16:26 ` Avi Kivity
2011-02-07 16:59 ` Jan Kiszka
2011-02-07 17:10 ` Avi Kivity [this message]
2011-02-07 17:23 ` Jan Kiszka
2011-02-08 9:15 ` Avi Kivity
2011-02-08 9:55 ` Jan Kiszka
2011-02-08 9:58 ` Avi Kivity
2011-02-10 10:40 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5027A1.8000505@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.