From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, 2nddept-manager@sdl.hitachi.co.jp,
Borislav Petkov <borislav.petkov@amd.com>,
Denis Kirjanov <dkirjanov@kernel.org>,
Franck Bui-Huu <fbuihuu@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Kyle McMartin <kyle@redhat.com>,
Michael Witten <mfwitten@gmail.com>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Stephane Eranian <eranian@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Tom Zanussi <tzanussi@gmail.com>
Subject: Re: [PATCH 0/9] perf/core improvements and fixes
Date: Tue, 08 Feb 2011 10:05:59 +0900 [thread overview]
Message-ID: <4D5096F7.7040206@hitachi.com> (raw)
In-Reply-To: <20110207173653.GC4470@ghostprotocols.net>
(2011/02/08 2:36), Arnaldo Carvalho de Melo wrote:
> Em Mon, Feb 07, 2011 at 02:29:16PM -0200, Arnaldo Carvalho de Melo escreveu:
>> Em Mon, Feb 07, 2011 at 04:06:40PM +0100, Ingo Molnar escreveu:
>>> * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
>>>> Masami Hiramatsu (4):
>>>> perf probe: Add bitfield member support
>>>
>>> hm, the perf probe bits do not build on 32-bit:
>>>
>>> util/probe-finder.c: In function ‘convert_variable_type’:
>>> util/probe-finder.c:881: error: format ‘%lu’ expects type ‘long unsigned int’, but argument 6 has type ‘unsigned int’
>>> util/probe-finder.c:881: error: format ‘%lu’ expects type ‘long unsigned int’, but argument 6 has type ‘unsigned int’
>>> make: *** [util/probe-finder.o] Error 1
>>> make: *** Waiting for unfinished jobs....
>>
>> I already reworked this and force pushed, see:
>>
>> http://git.kernel.org/?p=linux/kernel/git/acme/linux-2.6.git;a=commitdiff;h=2b4f8985a2c2309852d20d16d3589eba15b64c4e
>>
>> [ committer note: Fixed up '%lu' use for return of die_get_byte_size (int) ]
>
> Argh, I used '%d', which is ok on 32-bit, but then, breaks 64-bit, i.e.
> the right format is '%zd' since the expression is '... / sizeof(foo)',
> test built on both 64 and 32 bit, this time around it seems final.
>
> Just give it some time to go from master to git.k.o.
Oops, thanks Arnaldo and Ingo!
BTW, is there any good way to build 32bit perf on x86-64?
--
Masami HIRAMATSU
2nd Dept. Linux Technology Center
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
prev parent reply other threads:[~2011-02-08 1:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 15:00 [PATCH 0/9] perf/core improvements and fixes Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 1/9] perf tools: Makefile: Use $(QUIET_GEN) for perf.so Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 2/9] perf top: Use pid_t for target_{pid|tid} Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 3/9] perf probe: Rewrite find_lazy_match_lines() by using getline(3) Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 4/9] tracing/kprobes: Cleanup strict_strtol() using code Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 5/9] tracing/kprobes: Support longer (>128 bytes) command Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 6/9] tracing/kprobes: Add bitfield type Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 7/9] perf probe: Add bitfield member support Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 8/9] perf tool: Fix gcc 4.6.0 issues Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 9/9] perf annotate: Fix build error Arnaldo Carvalho de Melo
2011-02-07 15:06 ` [PATCH 0/9] perf/core improvements and fixes Ingo Molnar
2011-02-07 16:29 ` Arnaldo Carvalho de Melo
2011-02-07 17:36 ` Arnaldo Carvalho de Melo
2011-02-08 1:05 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5096F7.7040206@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=2nddept-manager@sdl.hitachi.co.jp \
--cc=acme@infradead.org \
--cc=borislav.petkov@amd.com \
--cc=dkirjanov@kernel.org \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fbuihuu@gmail.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=kyle@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfwitten@gmail.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.