All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Gix <bgix@codeaurora.org>
To: linux-bluetooth@vger.kernel.org, vinicius.gomes@openbossa.org
Subject: Re: Frequent SM test failure at UPF
Date: Mon, 07 Feb 2011 17:22:02 -0800	[thread overview]
Message-ID: <4D509ABA.1010909@codeaurora.org> (raw)
In-Reply-To: <4D508DC2.60003@codeaurora.org>

On 2/7/2011 4:26 PM, Brian Gix wrote:
>
> Testing of Shorter than 16 octet keys.
>
> In smp_cmd_pairing_random() when the STK is generated, it needs to be
> truncated to the MIN of conn->preq[4] and conn->pres[4].
>
> This Min value may need to be saved for later as well, because it needs
> to also limit the LTK key exchange.
>
> This failure showed up with the PTS tool, and at least one other device
> during the days testing. I have mocked up a fix, but have not had a
> chance to test it yet.
>
>

PTS also did not like that we request No Bonding, but request to 
exchange keys.  I am not sure who is at fault there. At first glance, 
exchanging keys insinuates a bonded relationship, so I don't know what 
it means to request key exchange but not bond.  I think both sides need 
to agree to bond (bit 0x01 in offset 3 (4th octet) of the req and res) 
to remember the exchanged keys, but exchanging keys should still be OK 
for the duration of that session at least.  They would then be discarded 
when the connection ended.

It also may not make sense to request Bonding, but not have keys to 
exchange, because I am not sure if you are really bonded if you have no 
keys exchanged with the remote device.  You could always just remember 
the remote device's BD Addr, I suppose and choose to accept or reject 
no-security connections based on that.

I am sorry, the above is mostly just me thinking out loud. I don't know 
for sure if any of that is actually correct.


-- 
Brian Gix
bgix@codeaurora.org
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

  reply	other threads:[~2011-02-08  1:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08  0:26 Frequent SM test failure at UPF Brian Gix
2011-02-08  1:22 ` Brian Gix [this message]
2011-02-08 13:58   ` Vinicius Costa Gomes
2011-02-08 17:35     ` Brian Gix
2011-02-08 23:29       ` SM Key Distribution Brian Gix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D509ABA.1010909@codeaurora.org \
    --to=bgix@codeaurora.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=vinicius.gomes@openbossa.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.