From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 15/27] nVMX: Prepare vmcs02 from vmcs01 and vmcs12 Date: Tue, 08 Feb 2011 14:39:32 +0200 Message-ID: <4D513984.9000109@redhat.com> References: <1287309814-nyh@il.ibm.com> <201010171011.o9HABFP1029474@rice.haifa.ibm.com> <4CBB037A.2050906@redhat.com> <20110208121315.GA28897@fermat.math.technion.ac.il> <4D513696.10501@redhat.com> <20110208123619.GA586@fermat.math.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, gleb@redhat.com To: "Nadav Har'El" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37298 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751519Ab1BHMji (ORCPT ); Tue, 8 Feb 2011 07:39:38 -0500 In-Reply-To: <20110208123619.GA586@fermat.math.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 02/08/2011 02:36 PM, Nadav Har'El wrote: > On Tue, Feb 08, 2011, Avi Kivity wrote about "Re: [PATCH 15/27] nVMX: Prepare vmcs02 from vmcs01 and vmcs12": > > >So isn't the first setting, in vmx_vcpu_setup(), redundant? > > > > It is. It's just historical baggage - these lines were introduced about > > 20 commits into kvm development (af9d6e204919016ca in qemu-kvm.git) and > > never removed, even after it was fixed to be per-cpu. > > Thanks. > > As part of my patch, I'm splitting off a function vmx_set_constant_host_state() > from vmx_vcpu_setup() (the same function will also be used to set up the host > state on vmcs02). So I'll remove that redundant setting from this function. Feel free to post cleanups like that as independent patches which can be merged immediately. -- error compiling committee.c: too many arguments to function