From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] sim: enable usage of SIM pass codes longer than 8 digits
Date: Tue, 08 Feb 2011 10:22:11 -0600 [thread overview]
Message-ID: <4D516DB3.5040406@gmail.com> (raw)
In-Reply-To: <1297169298-26209-1-git-send-email-jussi.kangas@tieto.com>
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
Hi Jussi,
On 02/08/2011 06:48 AM, Jussi Kangas wrote:
> ---
>
>
> Hi,
>
> On Tue, 2011-02-08 at 06:17 +0200, Denis Kenzior wrote:
>
> Why don't we keep things simple. Modify is_valid_pin to take a pin and
>> a min and max number of digits.
>>
>> gboolean is_valid_pin_with_limits(const char *pin, int min, int max)
>> (feel free to pick some better name)
>>
>> Then just add two functions:
>>
>> __ofono_valid_net_pin(const char *pin)
>> __ofono_valid_sim_pin(const char *pin, enum ofono_sim_password_type type)
>>
>> Stick both in ofono.h / sim.c somewhere
>>
>
> Right. Here it is.
I applied your patch, but it did have multiple problems, namely blank
line at EOF in sim.c, mixing tab/space for indentation and a compilation
warning. I was nice enough and fixed all these for you, but please pay
attention to this the next time.
Regards,
-Denis
next prev parent reply other threads:[~2011-02-08 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 12:48 [PATCH] sim: enable usage of SIM pass codes longer than 8 digits Jussi Kangas
2011-02-08 16:22 ` Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-07 14:49 Jussi Kangas
2011-02-08 4:17 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D516DB3.5040406@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.