From: Kamala Narasimhan <kamala.narasimhan@gmail.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 2/5] Xl interface change plus changes to code it impacts
Date: Tue, 08 Feb 2011 13:37:23 -0500 [thread overview]
Message-ID: <4D518D63.20305@gmail.com> (raw)
In-Reply-To: <1297175897.9388.114.camel@zakaz.uk.xensource.com>
Ian Campbell wrote:
> On Mon, 2011-02-07 at 21:22 +0000, Kamala Narasimhan wrote:
>> Attached are the changes made to xl disk related interface per earlier discussion. Please let me know if there are further comments/issues to fix.
>
> Please can you include a full/standalone commit message describing the
> change and the reasons for it etc, The reference to "earlier discussion"
> is likely to be lost with time.
>
Sure, will do when I send out a revised patch that addresses review comments.
> Did we decide to leave DISK_BACKEND_DEFAULT (i.e. libxl chooses based on
> the image type, host's backend support etc) for 4.2? I don't mind if we
> did but does that make "block-dev-type" as described in patch 1/5
> non-optional? (and therefore not really deprecated)
>
block-dev-type is still optional. Patch 5/5, the validation patch will take
care of the case when that optional attribute is not provided but the patches
submitted so far should have stop gap code that sets a fallback value.
Kamala
next prev parent reply other threads:[~2011-02-08 18:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 21:22 [PATCH 2/5] Xl interface change plus changes to code it impacts Kamala Narasimhan
2011-02-08 14:38 ` Ian Campbell
2011-02-08 14:41 ` Ian Campbell
2011-02-08 18:42 ` Kamala Narasimhan
2011-02-10 9:02 ` Ian Campbell
2011-02-10 14:37 ` Kamala Narasimhan
2011-02-08 18:37 ` Kamala Narasimhan [this message]
2011-02-08 15:42 ` Ian Jackson
2011-02-08 18:56 ` Kamala Narasimhan
2011-02-08 16:42 ` Stefano Stabellini
2011-02-08 19:04 ` Kamala Narasimhan
2011-02-08 19:09 ` Stefano Stabellini
-- strict thread matches above, loose matches on Subject: below --
2011-02-07 21:15 [PATCH 0/5] xl disk configuration handling Kamala Narasimhan
2011-02-09 18:21 ` [PATCH 2/5] Xl interface change plus changes to code it impacts Kamala Narasimhan
2011-02-10 9:23 ` Ian Campbell
2011-02-10 14:44 ` Kamala Narasimhan
2011-02-10 11:50 ` Stefano Stabellini
2011-02-10 17:05 ` Kamala Narasimhan
2011-02-10 20:00 ` Kamala Narasimhan
2011-02-11 13:47 ` Stefano Stabellini
2011-02-11 14:45 ` Kamala Narasimhan
2011-02-11 15:19 ` Kamala Narasimhan
2011-02-11 15:26 ` Stefano Stabellini
2011-02-11 19:12 ` Kamala Narasimhan
2011-02-14 17:45 ` Ian Jackson
2011-02-14 18:30 ` Kamala Narasimhan
2011-02-14 19:51 ` Kamala Narasimhan
2011-02-15 19:22 ` Ian Jackson
2011-02-15 19:38 ` Kamala Narasimhan
2011-02-15 19:41 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D518D63.20305@gmail.com \
--to=kamala.narasimhan@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.