From: Kamala Narasimhan <kamala.narasimhan@gmail.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 1/5] Xl Disk Configuration Option Documentation
Date: Tue, 08 Feb 2011 13:51:50 -0500 [thread overview]
Message-ID: <4D5190C6.5020403@gmail.com> (raw)
In-Reply-To: <19793.25071.677583.955339@mariner.uk.xensource.com>
Ian Jackson wrote:
> Kamala Narasimhan writes ("[xen-devel][PATCH 1/5] Xl Disk Configuration Option Documentation"):
>> Attached is a documentation of Xl disk configuration option that has already been reviewed.
>
> Thanks, this looks good. AIUI it describes the situation after the
> rest of your series has been applied so it should be committed after
> all the rest, or at least with the rest ?
>
Good point. I think it can go first as most part of it describes the current
state. But there are a couple of changes that switches some attributes to
optional that would be better handled once the rest of the patches are applied.
But the core details hasn't changed as much. So could be applied first IMO.
> There are a couple of tiny formatting issues which I can fix up when I
> commit it:
>
>> +Description: Qualifies virtual device type.
> ^^
> and the trailing whitespace.
>
> And:
>
>> + specifications). [ @TODO: Refer to IanJ's virtual
>> + disk specification here.]
>
> I think this TODO is fine to commit as-is, but you'll see that I've
> just reposted my vbd specification doc. Depending on the order of the
> commits I will fix this up.
>
Thanks for fixing up those.
Kamala
prev parent reply other threads:[~2011-02-08 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 21:19 [PATCH 1/5] Xl Disk Configuration Option Documentation Kamala Narasimhan
2011-02-08 15:31 ` Ian Jackson
2011-02-08 18:51 ` Kamala Narasimhan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5190C6.5020403@gmail.com \
--to=kamala.narasimhan@gmail.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.