Re: [PATCH 02/10] i2c-designware: split of i2c-designware.c into core and bus specific parts

[Shinya Kuribayashi <shinya.kuribayashi.px-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>]

On 2/9/2011 1:20 AM, Dirk Brandewie wrote:
> On 02/05/2011 09:45 AM, Ben Dooks wrote:
>>> @@ -347,15 +347,24 @@ config I2C_DAVINCI
>>>         devices such as DaVinci NIC.
>>>         For details please see http://www.ti.com/davinci
>>>
>>> -config I2C_DESIGNWARE
>>> -    tristate "Synopsys DesignWare"
>>> +config I2C_DESIGNWARE_PLATFORM
>>> +    tristate "Synopsys DesignWare Platfrom"
>>>       depends on HAVE_CLK
>>>       help
>>>         If you say yes to this option, support will be included for the
>>>         Synopsys DesignWare I2C adapter. Only master mode is supported.
>>>
>>>         This driver can also be built as a module.  If so, the module
>>> -      will be called i2c-designware.
>>> +      will be called i2c-designware-platform.
>>
>> not so happy about change in module name.

That's what I thought first, but I was optimistic about this.

> I am open to any name,  the current names come from Shinya's feedback.
> I will use what ever name everyone finds reasonable.

Okay, we have two courses.

 1. (re-)use current 'i2c-designware.ko' name for the platform driver
    (I mean i2c-designware-core.c + i2c-designware-plat) not to disturb
    existing users/systems, and give a new name for the PCI version
    (e.g. i2c-designware-pci).

 2. Use the same name both for the platform and the PCI drivers, and
    make only one driver to be configured using Kconfig.

Which one is a preferable course of action, Ben?
-- 
Shinya Kuribayashi
Renesas Electronics