Re: Hypervisor crash(!) on xl cpupool-numa-split

[Andre Przywara <andre.przywara@amd.com>]

Juergen Gross wrote:
>>> Another interesting thing to note is that the bug happened on pcpu 32,
>>> but there were no advertised migrations from that cpu.
> 
> If I understand the configuration of Andre's machine correctly, pcpu32 will
> be the target of the next migrations. This pcpu is member of the next numa
> node, correct?
No, this is a 6-core box, so the NUMA node span pcpu30-35.
> 
> Could it be there is a problem with the call of domain_update_node_affinity()
> from cpu_disable_scheduler() ?
> 
> Hmm, I think this could really be the problem.
> Andre, could you try the following patch?
Sorry, but that one didn't help. It crashed with the well-known BUG_ON:
(XEN) Xen BUG at sched_credit.c:990
(which is the weight assert in csched_acct (c/s 22858))

Regards,
Andre.

> 
> diff -r f1fac30a531b xen/common/schedule.c
> --- a/xen/common/schedule.c     Wed Feb 09 08:58:11 2011 +0000
> +++ b/xen/common/schedule.c     Wed Feb 09 14:02:12 2011 +0100
> @@ -491,6 +491,10 @@ int cpu_disable_scheduler(unsigned int c
>                           v->domain->domain_id, v->vcpu_id);
>                   cpus_setall(v->cpu_affinity);
>                   affinity_broken = 1;
> +            }
> +            if ( cpus_weight(v->cpu_affinity) < NR_CPUS )
> +            {
> +                cpu_clear(cpu, v->cpu_affinity);
>               }
> 
>               if ( v->processor == cpu )
> 
> 
> Juergen
> 


-- 
Andre Przywara
AMD-OSRC (Dresden)
Tel: x29712