Re: [PATCH 1/7] mac80211: Make STA disconnect messages warn instead of debug.

[Ben Greear <greearb@candelatech.com>]

On 02/09/2011 04:07 AM, Kalle Valo wrote:
> Ben Greear<greearb@candelatech.com>  writes:
>
>>> Messages like these are in the category "business as usual", which
>>> happens frequently when the device is moved. IMHO they are not really
>>> warnings. I'm worried that making the messages more visible might
>>> scare the users too much.
>>
>> To me it seems more useful than the network up/down messages that
>> are already printed from the networking core.
>
> You are not a normal user :) But what networking core messages are you
> referring to? I don't recall seeing anything like that.

ADDRCONF(NETDEV_CHANGE): sta6: link becomes ready
ADDRCONF(NETDEV_CHANGE): sta5: link becomes ready
ADDRCONF(NETDEV_CHANGE): sta4: link becomes ready

Possibly I previously hacked on the console logging levels and forgot
about it...

>
>> That said, I don't feel strongly about this change, and it's certainly
>> an easy patch for me to carry in my own tree.
>
> I also don't have any strong opinion about this, just voiced my
> concern.

No problem.  One final note:  These will only show if someone has
compiled in wireless debugging...

We can let the maintainer make the call :)

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com