From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx1.pokylinux.org (Postfix) with ESMTP id 7761E4C80053 for ; Wed, 9 Feb 2011 12:40:17 -0600 (CST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 09 Feb 2011 10:40:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.60,446,1291622400"; d="scan'208";a="656102521" Received: from unknown (HELO [10.255.14.215]) ([10.255.14.215]) by fmsmga002.fm.intel.com with ESMTP; 09 Feb 2011 10:40:16 -0800 Message-ID: <4D52DF80.4070702@linux.intel.com> Date: Wed, 09 Feb 2011 10:40:00 -0800 From: Darren Hart User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Adrian Alonso References: <1297196798-23779-1-git-send-email-yanok@emcraft.com> <1297196798-23779-3-git-send-email-yanok@emcraft.com> <4D52D210.6070905@linux.intel.com> In-Reply-To: Cc: poky@pokylinux.org, Ilya Yanok Subject: Re: [PATCH 3/3] u-boot: compile with -O2 on PowerPC X-BeenThere: poky@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Poky build system developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2011 18:40:17 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 02/09/2011 10:05 AM, Adrian Alonso wrote: > I observe that with current gcc for powerpc uboot only builds with > OPTFLAGS=-O2, unsetting or using other OPT level the build fails > with undefined symbols. > > I override the OPTFLAGS in the dedicated recipe for uboot under > meta-xilinx BSP > but for powerpc targets in main meta layer Ilya approach does the work. I see - shouldn't be reviewing patches with a head cold. I wonder if the -O2 would work with ARM as well. If so, we could just set OPTFLAGS to -O2 instead of '' for all architectures. I'd much prefer that if possible, I'll test on ARM. -- Darren > > On Wed, Feb 9, 2011 at 11:42 AM, Darren Hart > wrote: > > On 02/08/2011 12:26 PM, Ilya Yanok wrote: > > gcc on PowerPC is currently compiled with -Os optimization > disabled so > we have to use -O2 on PowerPC instead. > > Signed-off-by: Ilya Yanok > > --- > meta/recipes-bsp/uboot/u-boot.inc | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/meta/recipes-bsp/uboot/u-boot.inc > b/meta/recipes-bsp/uboot/u-boot.inc > index 6492016..7694c77 100644 > --- a/meta/recipes-bsp/uboot/u-boot.inc > +++ b/meta/recipes-bsp/uboot/u-boot.inc > @@ -22,7 +22,12 @@ do_compile () { > unset CFLAGS > unset CPPFLAGS > oe_runmake ${UBOOT_MACHINE} > - oe_runmake all > + # -Os is disabled on PowerPC > + if [ ${TARGET_ARCH} == "powerpc" ] ; then > + oe_runmake OPTFLAGS=-O2 all > + else > + oe_runmake all > + fi > > > > This is already disabled in u-boot.inc with the following line: > > # GCC 4.5.1 builds unusable binaries using -Os, remove it from OPTFLAGS > EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} OPTFLAGS=''" > > Resetting OPTFLAGS to '' removes the -Os from the variable in the > Makefile. This isn't just a PowerPC problem, it also manifested on > ARM, I believe it is a GCC 4.5.1 issue. > > -- > Darren Hart > Intel Open Source Technology Center > Yocto Project - Linux Kernel > > _______________________________________________ > poky mailing list > poky@yoctoproject.org > https://lists.yoctoproject.org/listinfo/poky > > -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel