From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yanok@emcraft.com>
Received: from ocean.emcraft.com (ocean.emcraft.com [213.221.7.182])
	by mx1.pokylinux.org (Postfix) with ESMTP id 108344C80053
	for <poky@pokylinux.org>; Wed,  9 Feb 2011 17:21:20 -0600 (CST)
Received: from localhost ([127.0.0.1] helo=[IPv6:::1])
	by ocean.emcraft.com with esmtp (Exim 4.71)
	(envelope-from <yanok@emcraft.com>)
	id 1PnJLZ-000820-D5; Thu, 10 Feb 2011 02:21:17 +0300
Message-ID: <4D53216D.4010908@emcraft.com>
Date: Thu, 10 Feb 2011 02:21:17 +0300
From: Ilya Yanok <yanok@emcraft.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; ru;
	rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7
MIME-Version: 1.0
To: Darren Hart <dvhart@linux.intel.com>
References: <1297196798-23779-1-git-send-email-yanok@emcraft.com>
	<1297196798-23779-3-git-send-email-yanok@emcraft.com>
	<4D52D210.6070905@linux.intel.com>
In-Reply-To: <4D52D210.6070905@linux.intel.com>
Cc: poky@pokylinux.org
Subject: Re: [PATCH 3/3] u-boot: compile with -O2 on PowerPC
X-BeenThere: poky@yoctoproject.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Poky build system developer discussion <poky.yoctoproject.org>
List-Unsubscribe: <https://lists.yoctoproject.org/options/poky>,
	<mailto:poky-request@yoctoproject.org?subject=unsubscribe>
List-Archive: <http://lists.yoctoproject.org/pipermail/poky>
List-Post: <mailto:poky@yoctoproject.org>
List-Help: <mailto:poky-request@yoctoproject.org?subject=help>
List-Subscribe: <https://lists.yoctoproject.org/listinfo/poky>,
	<mailto:poky-request@yoctoproject.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Feb 2011 23:21:21 -0000
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi Darren,

09.02.2011 20:42, Darren Hart wrote:
> This is already disabled in u-boot.inc with the following line:
>
> # GCC 4.5.1 builds unusable binaries using -Os, remove it from OPTFLAGS
> EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} OPTFLAGS=''"

Yes, sorry, I've useed not up-to-date version of metadata and missed 
this fix. But it has to be '-O2' still.

> Resetting OPTFLAGS to '' removes the -Os from the variable in the
> Makefile. This isn't just a PowerPC problem, it also manifested on ARM,
> I believe it is a GCC 4.5.1 issue.

Well, the difference here is that on PowerPC we have -Os option disabled 
completely. Wolfgang tried to summarize know gcc bugs and seems like -Os 
bugs on ARM and PowerPC have different nature (it looks like bugs on ARM 
are already fixed while on the ones PowerPC are not).
Then I think it's a bad idea to remove -Os everywhere: U-Boot really 
wants to be built with -Os optimization so we might want to change 
optimization level to -O2 only for targets where it's absolutely 
required. Actually I was able to build and successfully run U-Boot on 
beagleboard with -Os so it doesn't look like it's completely broken on ARM.

Regards, Ilya.