From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay1.mentorg.com ([192.94.38.131]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1PnJkT-00038c-PX for openembedded-devel@lists.openembedded.org; Thu, 10 Feb 2011 00:47:01 +0100 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1PnJjR-0003ZD-7U from Tom_Rini@mentor.com for openembedded-devel@lists.openembedded.org; Wed, 09 Feb 2011 15:45:57 -0800 Received: from na2-mail.mgc.mentorg.com ([134.86.114.213]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 9 Feb 2011 15:45:56 -0800 Received: from [172.30.80.130] ([172.30.80.130]) by na2-mail.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 9 Feb 2011 16:45:55 -0700 Message-ID: <4D53272F.1020400@mentor.com> Date: Wed, 09 Feb 2011 16:45:51 -0700 From: Tom Rini Organization: Mentor Graphics Corporation User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: openembedded-devel@lists.openembedded.org References: <1297199824-3712-1-git-send-email-morphis@gravedo.de> <4D51B81D.8000800@mentor.com> <20110209193129.GA15397@nirvana> <4D52EEE5.9030309@mentor.com> In-Reply-To: X-OriginalArrivalTime: 09 Feb 2011 23:45:56.0013 (UTC) FILETIME=[7EAC8DD0:01CBC8B3] Subject: Re: [PATCH] evas: disable cpu neon support for palmpre machine X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2011 23:47:02 -0000 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/09/2011 01:44 PM, Khem Raj wrote: > On Wed, Feb 9, 2011 at 11:45 AM, Tom Rini wrote: >> On 02/09/2011 12:31 PM, Simon Busch wrote: >>> >>> On 02/09/11 at 07:24pm, Koen Kooi wrote: >>>> >>>> -----BEGIN PGP SIGNED MESSAGE----- >>>> Hash: SHA1 >>> >>>> On 09-02-11 19:16, Khem Raj wrote: >>>>> >>>>> On Tue, Feb 8, 2011 at 1:39 PM, Tom Rini wrote: >>>>>> >>>>>> On 02/08/2011 02:17 PM, Simon Busch wrote: >>>>>>> >>>>>>> Neon support in evas is currently broken for the palmpre machine. If >>>>>>> we >>>>>>> enable neon >>>>>>> support evas causes alignment trap errors and lets the device freeze >>>>>>> in >>>>>>> the end. This >>>>>>> should be reverted after the bug in evas code is found and fixed. >>>>>>> >>>>>>> Signed-off-by: Simon Busch >>>>>>> --- >>>>>>> recipes/efl1/evas.inc | 5 ++++- >>>>>>> 1 files changed, 4 insertions(+), 1 deletions(-) >>>>>>> >>>>>>> diff --git a/recipes/efl1/evas.inc b/recipes/efl1/evas.inc >>>>>>> index eb64d7a..ad30eba 100644 >>>>>>> --- a/recipes/efl1/evas.inc >>>>>>> +++ b/recipes/efl1/evas.inc >>>>>>> @@ -7,7 +7,7 @@ DEPENDS_virtclass-native = "freetype-native >>>>>>> libxext-native >>>>>>> libpng-native jpeg-na >>>>>>> inherit efl >>>>>>> >>>>>>> BBCLASSEXTEND = "native" >>>>>>> -INC_PR = "r0" >>>>>>> +INC_PR = "r1" >>>>>>> FILESPATHPKG =. "${BPN}-${PV}:${BPN}:" >>>>>>> >>>>>>> python populate_packages_prepend () { >>>>>>> @@ -83,6 +83,9 @@ EVAS_CPU_TWEAKS = "" >>>>>>> # Disabled for now, see >>>>>>> >>>>>>> http://thread.gmane.org/gmane.comp.window-managers.enlightenment.devel/25194 >>>>>>> #EVAS_CPU_TWEAKS_armv7a = "--enable-cpu-neon" >>>>>>> >>>>>>> +# Neon support for evas is broken on palmpre currently (causes the >>>>>>> device >>>>>>> to freeze) >>>>>>> +EVAS_CPU_TWEAKS_palmpre = "--disable-cpu-neon" >>>>>>> + >>>>>>> # common options >>>>>>> EVAS_OECONF = " \ >>>>>>> --x-includes=${STAGING_INCDIR}/X11 \ >>>>>> >>>>>> Shouldn't this be changing the armv7a EVAS_CPU_TWEAKS that's above >>>>>> yours to >>>>>> be uncommented and as a --disable? >>>>> >>>>> that would disable neon for all armv7a machines probably not what is >>>>> needed here. >>> >>>> Actually, that was how I did it :) The NEON code that was added doesn't >>>> build with gcc 4.3.x and binutils 2.18.x, so I disabled it by not >>>> enabling it. If it builds and works with gcc 4.3.x nowadays we should >>>> enable it and find out why the palmpre breaks. >>> >>> Evas builds fine these days with neon support enabled but it enables it by >>> default. I really need to find the cause of the breakage on the palmpre >>> but >>> don't have too much time to debug it so this is a interim solution only >>> until the bug is found and fixed. > > that would be nice because once we add machine override it can become > a common escape for other machines > and changing this to be a machine specific recipe is not desired > unless absolutely needed > >> >> My only concern is that are we sure other armv7a targets aren't also having >> fatal problems? > > we don't fix what we don't know is broken Right. But it sounds like it shouldn't be too hard to see if it is broken elsewhere :) -- Tom Rini Mentor Graphics Corporation