All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Fix multiple qemu-options.def generation
Date: Thu, 10 Feb 2011 10:51:16 +0100	[thread overview]
Message-ID: <4D53B514.7050605@redhat.com> (raw)
In-Reply-To: <4560.09833510524$1294992458@news.gmane.org>

> diff --git a/Makefile.objs b/Makefile.objs
> index 4a1eaa1..ee9f190 100755
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -269,10 +269,10 @@ vl.o: QEMU_CFLAGS+=$(GPROF_CFLAGS)
>  vl.o: QEMU_CFLAGS+=$(SDL_CFLAGS)
> -vl.o: qemu-options.def
> +vl.o: ../qemu-options.def
> os-posix.o: qemu-options.def
> os-win32.o: qemu-options.def
> -qemu-options.def: $(SRC_PATH)/qemu-options.hx
> +%qemu-options.def: $(SRC_PATH)/qemu-options.hx
>                $(call quiet-command,sh $(SRC_PATH)/hxtool -h < $< > $@,"  GEN   $(TARGET_DIR)$@")

This is wrong, I think the problem is that you are missing a vpath 
directive.

Does this help?

diff --git a/rules.mak b/rules.mak
index ed59c9e..6f753ae 100644
--- a/rules.mak
+++ b/rules.mak
@@ -39,7 +39,7 @@ quiet-command = $(if $(V),$1,$(if $(2),@echo $2 && $1, @$1))
 cc-option = $(if $(shell $(CC) $1 $2 -S -o /dev/null -xc /dev/null \
               >/dev/null 2>&1 && echo OK), $2, $3)
 
-VPATH_SUFFIXES = %.c %.h %.S %.m %.mak %.texi
+VPATH_SUFFIXES = %.c %.h %.S %.m %.mak %.texi %.def
 set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES),$(eval vpath $(PATTERN) $1)))
 
 # find-in-path

Paolo

       reply	other threads:[~2011-02-10  9:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4560.09833510524$1294992458@news.gmane.org>
2011-02-10  9:51 ` Paolo Bonzini [this message]
2011-02-10  9:54   ` [Qemu-devel] Re: [PATCH] Fix multiple qemu-options.def generation Pavel Dovgaluk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D53B514.7050605@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=Pavel.Dovgaluk@ispras.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.