diff for duplicates of <4D53B9AC.8020609@bluewatersys.com> diff --git a/a/1.txt b/N1/1.txt index ee407ec..43a1b3c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -15,9 +15,9 @@ On 10/02/11 23:03, Richard Zhao wrote: >>> + int ret = 0; >>> + >>> + spin_lock_irqsave(&clk->enable_lock, flags); ->> WARN_ON(clk->prepare_count = 0); ? +>> WARN_ON(clk->prepare_count == 0); ? >> ->>> + if (clk->enable_count = 0&& clk->ops->enable) +>>> + if (clk->enable_count == 0&& clk->ops->enable) >>> + ret = clk->ops->enable(clk); >> Does it make sense to have a clock with no enable function which still >> returns success from clk_enable? Do we have any platforms which have diff --git a/a/content_digest b/N1/content_digest index a290fab..12a973f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,9 @@ "ref\01297233693.242364.862698430999.1.gpush@pororo\0" "ref\04D52F73A.4010707@bluewatersys.com\0" "ref\020110210100319.GB24710@b20223-02.ap.freescale.net\0" - "From\0Ryan Mallon <ryan@bluewatersys.com>\0" - "Subject\0Re: [RFC,PATCH 1/3] Add a common struct clk\0" - "Date\0Thu, 10 Feb 2011 10:10:52 +0000\0" + "From\0ryan@bluewatersys.com (Ryan Mallon)\0" + "Subject\0[RFC,PATCH 1/3] Add a common struct clk\0" + "Date\0Thu, 10 Feb 2011 23:10:52 +1300\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -24,9 +24,9 @@ ">>> + int ret = 0;\n" ">>> +\n" ">>> + spin_lock_irqsave(&clk->enable_lock, flags);\n" - ">> WARN_ON(clk->prepare_count = 0); ?\n" + ">> WARN_ON(clk->prepare_count == 0); ?\n" ">>\n" - ">>> + if (clk->enable_count = 0&& clk->ops->enable)\n" + ">>> + if (clk->enable_count == 0&& clk->ops->enable)\n" ">>> + ret = clk->ops->enable(clk);\n" ">> Does it make sense to have a clock with no enable function which still\n" ">> returns success from clk_enable? Do we have any platforms which have\n" @@ -52,4 +52,4 @@ "\n" ~Ryan -d41b539aa7a65d5bc8c96eafc132a218ec6fb12b73d660781c8bf3405ecf63e1 +32bd1fcf96bf51c88aecd619cdcb0fbc9338edaab52a7c4814c846131c39306b
diff --git a/a/1.txt b/N2/1.txt index ee407ec..43a1b3c 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -15,9 +15,9 @@ On 10/02/11 23:03, Richard Zhao wrote: >>> + int ret = 0; >>> + >>> + spin_lock_irqsave(&clk->enable_lock, flags); ->> WARN_ON(clk->prepare_count = 0); ? +>> WARN_ON(clk->prepare_count == 0); ? >> ->>> + if (clk->enable_count = 0&& clk->ops->enable) +>>> + if (clk->enable_count == 0&& clk->ops->enable) >>> + ret = clk->ops->enable(clk); >> Does it make sense to have a clock with no enable function which still >> returns success from clk_enable? Do we have any platforms which have diff --git a/a/content_digest b/N2/content_digest index a290fab..ff80f90 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,8 +3,23 @@ "ref\020110210100319.GB24710@b20223-02.ap.freescale.net\0" "From\0Ryan Mallon <ryan@bluewatersys.com>\0" "Subject\0Re: [RFC,PATCH 1/3] Add a common struct clk\0" - "Date\0Thu, 10 Feb 2011 10:10:52 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Thu, 10 Feb 2011 23:10:52 +1300\0" + "To\0Richard Zhao <richard.zhao@freescale.com>\0" + "Cc\0Jeremy Kerr <jeremy.kerr@canonical.com>" + Nicolas Pitre <nicolas.pitre@linaro.org> + Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com> + Vincent Guittot <vincent.guittot@linaro.org> + linux-sh@vger.kernel.org + Ben Herrenschmidt <benh@kernel.crashing.org> + Sascha Hauer <s.hauer@pengutronix.de> + Paul Mundt <lethal@linux-sh.org> + linux-kernel@vger.kernel.org + Dima Zavin <dmitriyz@google.com> + Saravana Kannan <skannan@codeaurora.org> + Ben Dooks <ben-linux@fluff.org> + " Uwe Kleine-K\303\266nig <u.kleine-koenig@pengutronix.de>" + Russell King <linux@arm.linux.org.uk> + " linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On 10/02/11 23:03, Richard Zhao wrote:\n" @@ -24,9 +39,9 @@ ">>> + int ret = 0;\n" ">>> +\n" ">>> + spin_lock_irqsave(&clk->enable_lock, flags);\n" - ">> WARN_ON(clk->prepare_count = 0); ?\n" + ">> WARN_ON(clk->prepare_count == 0); ?\n" ">>\n" - ">>> + if (clk->enable_count = 0&& clk->ops->enable)\n" + ">>> + if (clk->enable_count == 0&& clk->ops->enable)\n" ">>> + ret = clk->ops->enable(clk);\n" ">> Does it make sense to have a clock with no enable function which still\n" ">> returns success from clk_enable? Do we have any platforms which have\n" @@ -52,4 +67,4 @@ "\n" ~Ryan -d41b539aa7a65d5bc8c96eafc132a218ec6fb12b73d660781c8bf3405ecf63e1 +bb924ca088b0b70eb6a67659041c5d276ecfd90f15bc11f9da4b52c7787a338a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.