All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, Alexander Kjeldaas <astor@fast.no>,
	David Woodhouse <David.Woodhouse@intel.com>,
	Herbert Xu <herbert@gondor.hengli.com.au>,
	Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: NULL deref in drivers/md/dm-crypt.c:crypt_convert()
Date: Fri, 11 Feb 2011 08:37:55 +0100	[thread overview]
Message-ID: <4D54E753.9090906@redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1102102004140.26035@swampdragon.chaosbits.net>

On 02/10/2011 08:14 PM, Jesper Juhl wrote:
> On Sun, 6 Feb 2011, Milan Broz wrote:
> 
> If you have a coverity scan account it is CID 40766. But since you ask I 
> assume you do not have an account, so I've also pasted the output from 
> their web interface here :

Thanks.

I would say that the checker has problem to follow per cpu pointers...

In this case
static struct crypt_cpu *this_crypt_config(struct crypt_config *cc)
{
        return this_cpu_ptr(cc->cpu);

Otherwise it must see that the struct is allocated in
crypt_alloc_req(cc, ctx);

And mempool allocation should never return NULL here.

Milan

  reply	other threads:[~2011-02-11  7:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-06 22:31 NULL deref in drivers/md/dm-crypt.c:crypt_convert() Jesper Juhl
2011-02-06 22:50 ` Milan Broz
2011-02-10 19:14   ` Jesper Juhl
2011-02-11  7:37     ` Milan Broz [this message]
2011-02-11  9:26       ` Jesper Juhl
2011-02-11 10:01         ` Milan Broz
2011-02-11 11:04           ` Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D54E753.9090906@redhat.com \
    --to=mbroz@redhat.com \
    --cc=David.Woodhouse@intel.com \
    --cc=astor@fast.no \
    --cc=herbert@gondor.hengli.com.au \
    --cc=jj@chaosbits.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.